From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105743 invoked by alias); 18 Nov 2018 18:42:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105731 invoked by uid 89); 18 Nov 2018 18:42:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=surprised, H*c:US-ASCII, fwiw X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 18 Nov 2018 18:42:45 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14DFF3082DD5; Sun, 18 Nov 2018 18:42:44 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E00601A7E8; Sun, 18 Nov 2018 18:42:43 +0000 (UTC) Date: Sun, 18 Nov 2018 18:42:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: John Darrington Subject: Re: [PATCH 1/2] GDB: S12Z: Add assertion Message-ID: <20181118114242.675f5f14@pinnacle.lan> In-Reply-To: <20181118092258.wmiltm7lfzj2cvnw@jocasta.intra> References: <20181112091721.28040-1-john@darrington.wattle.id.au> <20181117145928.726522e6@pinnacle.lan> <20181118092258.wmiltm7lfzj2cvnw@jocasta.intra> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00280.txt.bz2 On Sun, 18 Nov 2018 10:22:58 +0100 John Darrington wrote: > On Sat, Nov 17, 2018 at 02:59:28PM -0700, Kevin Buettner wrote: > > > --- > > gdb/s12z-tdep.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c > > index 79f5772035..bd0bd7c001 100644 > > --- a/gdb/s12z-tdep.c > > +++ b/gdb/s12z-tdep.c > > @@ -320,6 +320,7 @@ s12z_frame_cache (struct frame_info *this_frame, void **prologue_cache) > > } > > else > > { > > + gdb_assert (this_sp == this_sp_for_id); > > /* The stack pointer of the prev frame is frame_size greater > > than the stack pointer of this frame plus one address > > size (caused by the JSR or BSR). */ > > -- > > Could you please add a ChangeLog entry? > > Also, on the same topic, what happened to the ChangeLog entries > for the initial commit / push of the s12z port? (I don't see them > in the ChangeLog file.) > > Is it really necessary in 2018 to have ChangeLogs? After all, the same > information is available by typing git log and/or git diff. If the answer is > "yes", then how about generating it automatically using the git-log-to-changelog > script which is available in gnulib ? Many other projects have gone over to > this method. > > ChangeLogs are a dreaded nuisance. They are almost guaranteed to cause merge > conflicts. The information they contain is redundant. Their formatting > requirements are onerous. And in thirty years of software development, I don't > think I've ever experienced a case where I've needed to refer to one. While I agree with some of your arguments against the use of ChangeLogs in 2018, the GDB project still requires the use of ChangeLogs. See: https://sourceware.org/gdb/wiki/ContributionChecklist#ChangeLog and: https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog And, FWIW, the first thing that I did while reviewing your patches was to look at the current ChangeLog to get a brief history of changes to s12z-tdep.c. I was surprised when I did not find any ChangeLog entries, though I did figure it out by consulting the git log. Kevin