From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85055 invoked by alias); 27 Nov 2018 11:21:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85041 invoked by uid 89); 27 Nov 2018 11:21:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm1-f67.google.com Received: from mail-wm1-f67.google.com (HELO mail-wm1-f67.google.com) (209.85.128.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Nov 2018 11:21:16 +0000 Received: by mail-wm1-f67.google.com with SMTP id 125so21484711wmh.0 for ; Tue, 27 Nov 2018 03:21:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=m0dyju7v18Juecc+Whdp3+n1ZX3pshePUwUtGja4jmo=; b=LBV2LVSOoMl1Ca5VwZm1l3JDCJHDex1ur6kItnkbUe+RFJQ+A2RZ8uVv3kh8FmuCRm sx8/ZarNiGLnsY1Wo9RuGP+vDAdOsSqGDyImdz7+H5whU+I+HnRU9RgJEJTemrhEvR9e HYVQ1z0KkC073rmAr0udX+3w2opNmeAuGpFEuvdb7gMK+dOBi7SkMkanAl+qysQfiuhW 9SNDw7Vc/OtIyl5MrCog+VAOV0PXtvirTPOuiD3O7YD9cGgtVhImj9b/6PWfpOi/iDDJ laVvt1R4pLaMjz7AsvnF9FgCbOlbiD+Nb9sYqDDo2kYFBD0yH/w51ez04hMlVWCS+K8J 4j/g== Return-Path: Received: from localhost (host86-156-236-171.range86-156.btcentralplus.com. [86.156.236.171]) by smtp.gmail.com with ESMTPSA id 80sm5636536wmv.6.2018.11.27.03.21.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Nov 2018 03:21:13 -0800 (PST) Date: Tue, 27 Nov 2018 11:21:00 -0000 From: Andrew Burgess To: Simon Marchi Cc: gdb-patches@sourceware.org, vapier@gentoo.org Subject: Re: [PATCH 1/2] sim/opcodes: Allow use of out of tree cgen source directory Message-ID: <20181127112112.GC2834@embecosm.com> References: <0745ff244d76a8cd8ec7e7b9a53840f3773a139d.1541525137.git.andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: The sooner you fall behind, the more time you have to catch up. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00456.txt.bz2 * Simon Marchi [2018-11-26 16:07:35 -0500]: > On 2018-11-06 12:35, Andrew Burgess wrote: > > diff --git a/opcodes/configure.ac b/opcodes/configure.ac > > index 4c3698356b..9e48fedf9a 100644 > > --- a/opcodes/configure.ac > > +++ b/opcodes/configure.ac > > @@ -109,11 +109,21 @@ AC_ARG_ENABLE(cgen-maint, > > yes) cgen_maint=yes ;; > > no) cgen_maint=no ;; > > *) > > - # argument is cgen install directory (not implemented yet). > > - # Having a `share' directory might be more appropriate for the .scm, > > - # .cpu, etc. files. > > + # Argument is a directory where cgen can be found. In some > > + # future world cgen could be installable, but right now this > > + # is not the case. Instead we assume the directory is a path > > + # to the cgen source tree. > > cgen_maint=yes > > - cgendir=${cgen_maint}/lib/cgen > > + if test -r ${enableval}/iformat.scm; then > > + # This looks like a cgen source tree. > > + cgendir=${enableval} > > + else > > + # This code would handle a cgen install. For now we assume > > + # 'lib', but this is really just a place holder. Maybe > > + # having a `share' directory might be more appropriate for > > + # the .scm, .cpu, etc. files. > > + cgendir=${enableval}/lib/cgen > > + fi > > ;; > > esac])dnl > > AM_CONDITIONAL(CGEN_MAINT, test x${cgen_maint} = xyes) > > Just wondering, does the "else" part have any real-world use? Before today, > was there any reason to pass a path to --enable-cgen-maint ? Thanks for taking a look at this patch :) Not as far as I can tell. I left it in just in case, but as far as I can tell there's no way to "install" CGEN. I'd be happy to drop the ../lib/cgen references (the else block) completely, and then validate that we have a CGEN source tree or error.... But the above seemed like the least invasive change. Andrew