From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 05/16] Add output styles to gdb
Date: Mon, 24 Dec 2018 04:08:00 -0000 [thread overview]
Message-ID: <20181224040748.GH5246@adacore.com> (raw)
In-Reply-To: <20181128001435.12703-6-tom@tromey.com>
> gdb/ChangeLog
> 2018-11-27 Tom Tromey <tom@tromey.com>
>
> * utils.h (set_output_style, fprintf_styled)
> (fputs_styled): Declare.
> * utils.c (applied_style, desired_style): New globals.
> (emit_style_escape, set_output_style): New function.
> (prompt_for_continue): Emit style escapes.
> (fputs_maybe_filtered): Likewise.
> (fputs_styled, fprintf_styled): New functions.
> * ui-out.h (enum class ui_out_style_kind): New.
> (class ui_out) <field_string, field_stream, do_field_string>: Add
> style parameter.
> * ui-out.c (ui_out::field_stream, ui_out::field_string): Add style
> parameter.
> * tui/tui-out.h (class tui_ui_out) <do_field_string>: Add style
> parameter.
> * tui/tui-out.c (tui_ui_out::do_field_string): Add style
> parameter.
> (tui_ui_out::do_field_string): Update.
> * tracepoint.c (print_one_static_tracepoint_marker): Style
> output.
> * stack.c (print_frame_info, print_frame): Style output.
> * source.c (print_source_lines_base): Style output.
> * skip.c (info_skip_command): Style output.
> * record-btrace.c (btrace_call_history_src_line): Style output.
> (btrace_call_history): Likewise.
> * python/py-framefilter.c (py_print_frame): Style output.
> * mi/mi-out.h (class mi_ui_out) <do_field_string>: Add style
> parameter.
> * mi/mi-out.c (mi_ui_out::do_table_header)
> (mi_ui_out::do_field_int): Update.
> (mi_ui_out::do_field_string): Update.
> * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
> Style output.
> * cli/cli-style.h: New file.
> * cli/cli-style.c: New file.
> * cli-out.h (class cli_ui_out) <do_field_string>: Add style
> parameter.
> * cli-out.c (cli_ui_out::do_table_header)
> (cli_ui_out::do_field_int, cli_ui_out::do_field_skip): Update.
> (cli_ui_out::do_field_string): Add style parameter. Style the
> output.
> * breakpoint.c (print_breakpoint_location): Style output.
> (update_static_tracepoint): Likewise.
> * Makefile.in (SUBDIR_CLI_SRCS): Add cli-style.c.
> (HFILES_NO_SRCDIR): Add cli-style.h.
>
> gdb/testsuite/ChangeLog
> 2018-11-27 Tom Tromey <tom@tromey.com>
>
> * gdb.base/style.exp: New file.
> * gdb.base/style.c: New file.
I tried to think about other ways to decide whether styling is
supported or not, but at the end of the day, Athis is just a detail,
and we can always come back to it. In the meantime, I think what
you've done should be good enough. I assume there aren't that
many terminals out there that don't support ansi colorizing.
The patch looks good to me overall. Just a few very minor nits.
> +void
> +cli_style_option::add_setshow_commands (const char *name,
> + enum command_class theclass,
> + const char *prefix_doc,
> + const char *prefixname,
> + struct cmd_list_element **set_list,
> + struct cmd_list_element **show_list)
> +{
> + m_show_prefix = std::string ("set ") + prefixname + " ";
> + m_show_prefix = std::string ("show ") + prefixname + " ";
> +
> + add_prefix_cmd (name, no_class, do_set, prefix_doc, &m_set_list,
Small nit: Trailing space here...
> @@ -1182,7 +1185,7 @@ print_frame (struct frame_info *frame, int print_level,
> string_file stb;
> fprintf_symbol_filtered (&stb, funname ? funname.get () : "??",
> funlang, DMGL_ANSI);
> - uiout->field_stream ("func", stb);
> + uiout->field_stream ("func", stb, ui_out_style_kind::FUNCTION);
> uiout->wrap_hint (" ");
> annotate_frame_args ();
>
Another one here as well.
> +++ b/gdb/testsuite/gdb.base/style.c
> @@ -0,0 +1,22 @@
> +/* Copyright 2018 Free Software Foundation, Inc.
> +
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 3 of the License, or
> + (at your option) any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program. If not, see <http://www.gnu.org/licenses/>. */
> +
> +#include <stdio.h>
Can we remove the #include in this case?
> +save_vars { env(TERM) } {
> + # We need an ANSI-capable terminal to get the output.
> + setenv TERM ansi
> +
> + if {[prepare_for_testing "failed to prepare" $testfile $srcfile]} {
> + return -1
> + }
> +
> + if {![runto_main]} {
> + fail "style tests failed"
> + return
> + }
> +
> + gdb_test_no_output "set style enabled on"
> +
Nit: A few trailing spaces here...
--
Joel
next prev parent reply other threads:[~2018-12-24 4:08 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 0:16 [PATCH 00/16] Add styling to the gdb CLI and TUI Tom Tromey
2018-11-28 0:14 ` [PATCH 10/16] Style the gdb welcome message Tom Tromey
2018-11-28 0:14 ` [PATCH 02/16] Add a "context" argument to add_setshow_enum_cmd Tom Tromey
2018-11-28 0:14 ` [PATCH 03/16] Introduce ui_file_style Tom Tromey
2018-12-24 3:40 ` Joel Brobecker
2018-12-28 18:54 ` Tom Tromey
2018-11-28 0:14 ` [PATCH 05/16] Add output styles to gdb Tom Tromey
2018-12-24 4:08 ` Joel Brobecker [this message]
2018-12-28 18:55 ` Tom Tromey
2018-11-28 0:14 ` [PATCH 06/16] Reset terminal styles Tom Tromey
2018-12-24 4:16 ` Joel Brobecker
2018-12-28 19:01 ` Tom Tromey
2018-11-28 0:14 ` [PATCH 14/16] Use wclrtoeol in tui_show_source_line Tom Tromey
2018-12-24 8:03 ` Joel Brobecker
2018-11-28 0:14 ` [PATCH 09/16] Style print_address_symbolic Tom Tromey
2018-11-28 0:14 ` [PATCH 12/16] Style addresses Tom Tromey
2018-11-28 0:16 ` [PATCH 11/16] Style the "Reading symbols" message Tom Tromey
2018-11-28 0:16 ` [PATCH 08/16] Style locations when setting a breakpoint Tom Tromey
2018-11-28 0:16 ` [PATCH 07/16] Style variable names Tom Tromey
2018-11-28 0:16 ` [PATCH 13/16] Make ANSI terminal escape sequences work in TUI Tom Tromey
2018-12-24 8:02 ` Joel Brobecker
2018-12-28 19:42 ` Tom Tromey
2018-11-28 0:16 ` [PATCH 16/16] Document the "set style" commands Tom Tromey
2018-11-28 6:51 ` Eli Zaretskii
2018-12-28 19:19 ` Tom Tromey
2018-11-28 0:16 ` [PATCH 15/16] Highlight source code using GNU Source Highlight Tom Tromey
2019-11-16 0:58 ` Andrew Pinski
2019-11-16 8:19 ` Eli Zaretskii
2019-11-24 17:41 ` Tom Tromey
2019-11-24 18:13 ` Christian Biesinger via gdb-patches
2019-11-24 19:53 ` Tom Tromey
2018-11-28 0:16 ` [PATCH 04/16] Change gdb test suite's TERM setting Tom Tromey
2018-11-28 0:19 ` [PATCH 01/16] Change wrap buffering to use a std::string Tom Tromey
2018-12-23 15:26 ` Joel Brobecker
2018-12-28 18:47 ` Tom Tromey
2018-11-28 7:02 ` [PATCH 00/16] Add styling to the gdb CLI and TUI Eli Zaretskii
2018-11-29 22:44 ` Tom Tromey
2018-11-30 7:02 ` Eli Zaretskii
2018-11-30 16:17 ` Tom Tromey
2018-12-23 10:49 ` Joel Brobecker
2019-03-01 13:10 ` Pedro Alves
2019-03-01 13:56 ` Eli Zaretskii
2019-03-01 14:10 ` Pedro Alves
2019-03-01 14:50 ` Eli Zaretskii
2019-03-01 7:47 ` Eli Zaretskii
2019-03-01 18:42 ` Tom Tromey
2019-03-01 19:40 ` Eli Zaretskii
2019-03-01 21:04 ` Tom Tromey
2019-03-02 7:15 ` Eli Zaretskii
2019-03-03 15:42 ` Eli Zaretskii
2019-03-04 15:08 ` Tom Tromey
2019-03-04 15:57 ` Eli Zaretskii
2019-03-04 16:16 ` Tom Tromey
2019-03-05 15:38 ` Eli Zaretskii
2019-03-08 14:55 ` Eli Zaretskii
2019-03-08 16:14 ` Hannes Domani via gdb-patches
2019-03-08 21:08 ` Tom Tromey
2019-03-08 21:11 ` Tom Tromey
2019-03-09 6:49 ` Eli Zaretskii
2019-03-03 15:53 ` Eli Zaretskii
2019-03-03 16:16 ` Matt Rice
2019-03-03 17:13 ` Eli Zaretskii
2019-03-03 18:04 ` Matt Rice
2019-03-04 15:01 ` Tom Tromey
2019-03-04 17:37 ` Eli Zaretskii
2019-03-04 17:40 ` Tom Tromey
2019-03-06 16:02 ` Eli Zaretskii
2019-03-20 19:35 ` GDB version as convenience variable Eli Zaretskii
2019-03-25 17:31 ` Eli Zaretskii
2019-03-25 17:58 ` Simon Marchi
2019-03-25 18:10 ` Eli Zaretskii
2019-03-25 18:33 ` Simon Marchi
2019-03-25 18:37 ` Simon Marchi
2019-03-25 18:43 ` Eli Zaretskii
2019-03-25 18:51 ` Simon Marchi
2019-03-25 19:19 ` Eli Zaretskii
2019-03-26 14:47 ` Simon Marchi
2019-03-26 20:57 ` Joel Brobecker
2019-03-27 3:34 ` Eli Zaretskii
2019-03-27 12:56 ` Joel Brobecker
2019-03-30 17:25 ` Simon Marchi
2019-03-30 10:01 ` Eli Zaretskii
2019-03-21 1:55 ` [PATCH 00/16] Add styling to the gdb CLI and TUI Simon Marchi
2019-03-21 14:38 ` Eli Zaretskii
2019-03-21 15:02 ` Simon Marchi
2019-03-21 16:01 ` Eli Zaretskii
2019-03-21 16:06 ` Simon Marchi
2019-03-21 16:12 ` Pedro Alves
2019-03-21 16:54 ` John Baldwin
2019-03-21 17:02 ` Eli Zaretskii
2019-03-21 18:08 ` Simon Marchi
2019-03-21 18:19 ` Pedro Alves
2019-03-21 18:38 ` Eli Zaretskii
2019-03-07 6:02 ` Joel Brobecker
2019-03-07 14:53 ` Eli Zaretskii
2019-03-08 5:40 ` Joel Brobecker
2019-03-04 16:04 ` Eli Zaretskii
2018-12-24 9:27 ` Joel Brobecker
2018-12-28 20:57 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181224040748.GH5246@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).