From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79519 invoked by alias); 24 Dec 2018 08:02:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79509 invoked by uid 89); 24 Dec 2018 08:02:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=shutting, Clean, too! X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Dec 2018 08:02:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0E78511710B; Mon, 24 Dec 2018 03:02:18 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id V4ItCOqg73eA; Mon, 24 Dec 2018 03:02:17 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6EA0D117082; Mon, 24 Dec 2018 03:02:17 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B37D286756; Mon, 24 Dec 2018 12:02:11 +0400 (+04) Date: Mon, 24 Dec 2018 08:02:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 13/16] Make ANSI terminal escape sequences work in TUI Message-ID: <20181224080211.GJ5246@adacore.com> References: <20181128001435.12703-1-tom@tromey.com> <20181128001435.12703-14-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181128001435.12703-14-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-12/txt/msg00294.txt.bz2 > I am very sour on the curses design now. I would be too! > gdb/ChangeLog > 2018-11-27 Tom Tromey > > PR tui/14126: > * tui/tui.c (tui_enable): Call start_color and > use_default_colors. > * tui/tui-io.c (struct color_pair): New. > (color_pair_map, last_color_pair, last_style): New globals. > (tui_setup_io): Clean up color map when shutting down. > (curses_colors): New constant. > (get_color_pair, apply_ansi_escape): New functions. > (tui_write): Rewrite. > (tui_puts_internal): New function, from tui_puts. Add "height" > parameter. > (tui_puts): Use tui_puts_internal. > (tui_redisplay_readline): Use tui_puts_internal. > (_initialize_tui_io): New function. > (color_map): New globals. > (get_color): New function. > * configure.ac: Check for use_default_colors. > * config.in, configure: Rebuild. I scan the patch. I didn't go into too much detail, but for what it's worth, what I read made sense to me. -- Joel