From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15238 invoked by alias); 25 Jan 2019 04:17:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15226 invoked by uid 89); 25 Jan 2019 04:17:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Jan 2019 04:17:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0F1B4116201; Thu, 24 Jan 2019 23:17:51 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id pJgSwkp296Xl; Thu, 24 Jan 2019 23:17:50 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 904771161FB; Thu, 24 Jan 2019 23:17:50 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id AC783857A4; Fri, 25 Jan 2019 08:17:44 +0400 (+04) Date: Fri, 25 Jan 2019 04:17:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Normalize common includes Message-ID: <20190125041744.GC7566@adacore.com> References: <20190123172954.24421-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190123172954.24421-1-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-01/txt/msg00544.txt.bz2 > I think the norm in gdb is to include files from common using > "common/filename.h" -- but this is not enforced, because the Makefiles > provide -I$(srcdir)/common. > > This series rewrites gdb to use the norm everywhere, and then removes > the -I options. The bulk of the change was done by script. > > Let me know what you think. It would be better for this to go in (if > it goes in) before the include sorting patch. I think it's a good idea indeed. It's immediately clearer to me when I see #include "common/something.h". The downside is having to update all the includes when we move one file, but I think this one-off is worth the extra clarity. -- Joel