From: Kevin Buettner <kevinb@redhat.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix type_stack leaks in c expression parsing.
Date: Sun, 10 Feb 2019 00:31:00 -0000 [thread overview]
Message-ID: <20190209173134.56bfe46e@f29-4.lan> (raw)
In-Reply-To: <20190209195000.23057-1-philippe.waroquiers@skynet.be>
On Sat, 9 Feb 2019 20:50:00 +0100
Philippe Waroquiers <philippe.waroquiers@skynet.be> wrote:
> Fix these by storing the allocated type_stack in the cpstate->type_stacks
> vector.
>
> Tested on debian/amd64, natively and under valgrind.
>
> gdb/ChangeLog
> 2019-02-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> * c-exp.y (direct_abs_decl): emplace_back type_stack.
The actual changes in your patch look good to me.
One nit regarding the ChangeLog entry though - I think we strive to
make our ChangeLog remarks look like sentences where the first word
is capitalized. So... maybe something like:
* c-exp.y (direct_abs_decl): Use emplace_back to record the
type_stack.
If you can think of a better ChangeLog comment, that's fine too.
Kevin
next prev parent reply other threads:[~2019-02-10 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 19:50 Philippe Waroquiers
2019-02-10 0:31 ` Kevin Buettner [this message]
2019-02-10 12:18 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209173134.56bfe46e@f29-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).