From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81228 invoked by alias); 14 Feb 2019 03:34:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81196 invoked by uid 89); 14 Feb 2019 03:34:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=choices, Youll, You'll X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Feb 2019 03:34:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3022656094; Wed, 13 Feb 2019 22:34:37 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0iR8GDpElWjW; Wed, 13 Feb 2019 22:34:37 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BFF37117FB0; Wed, 13 Feb 2019 22:34:36 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 99F53838BA; Thu, 14 Feb 2019 07:34:32 +0400 (+04) Date: Thu, 14 Feb 2019 03:34:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [RFC] Fix pager bugs with style output Message-ID: <20190214033432.GC2945@adacore.com> References: <20190209183721.3486-1-tom@tromey.com> <20190210123813.GA31881@adacore.com> <20190212135348.GY2829@embecosm.com> <87sgwt6ik4.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sgwt6ik4.fsf@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-02/txt/msg00214.txt.bz2 > Andrew> I don't have a solution, but the issue here is that in > Andrew> user_select_syms output is produced with printf_unfiltered, by passing > Andrew> the line wrapping buffer, however, the symbol name is produced by a > Andrew> call to ada_print_symbol_signature which uses fprintf_filtered, > Andrew> placing the output into the line wrap buffer. > > Thanks for looking into this. > > Andrew> You'll need to reconcile these two things. > > Andrew> Given that ada_print_symbol_signature only seems to be called in areas > Andrew> that are using unfiltered printing, simply changing > Andrew> ada_print_symbol_signature to also use unfiltered printing should > Andrew> provide a solution. > > How about having user_select_syms also use filtered output? > That seems like it would be somewhat friendlier in the unlikely event > that the menu was very long -- it would give the user a chance to read > the choices. I think it makes sense, especially now that you enhanced the paging to allow us to print everything without being asked about paging anymore. It should be fairly easy to revert back if we find that this is causing unforseen problems. -- Joel