From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88720 invoked by alias); 15 Feb 2019 02:13:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88649 invoked by uid 89); 15 Feb 2019 02:13:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=20181026, 2018-10-26, 0x24, 0x2d X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Feb 2019 02:13:27 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E5877C0D2249; Fri, 15 Feb 2019 02:13:25 +0000 (UTC) Received: from f29-4.lan (ovpn-117-11.phx2.redhat.com [10.3.117.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B03275D705; Fri, 15 Feb 2019 02:13:25 +0000 (UTC) Date: Fri, 15 Feb 2019 02:13:00 -0000 From: Kevin Buettner To: binutils@sourceware.org, Saagar Jha Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Use new Darwin operating system names Message-ID: <20190214191325.2354ddbc@f29-4.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00249.txt.bz2 On Fri, 26 Oct 2018 21:57:37 -0700 Saagar Jha wrote: > Replace MacOSX with macOS, IOS with iOS, and WatchOS with watchOS. >=20 > ChangeLog: > 2018-10-26 Saagar Jha >=20 > * include/mach-o/loader.h: Use new OS names. A couple of nits regarding the ChangeLog entry... 1) This entry should go in include/ChangeLog, so you don't need to have the include/ prefix. 2) Please adjust it to indicate that only the comments are affected.=20 Like this, perhaps: * mach-o/loader.h: Use new OS names in comments. Otherwise, it looks good to me. I wish I could tell you to check this in, but I think that the binutils maintainers will need to approve this change. I've added binutils@sourceware.org to the "To:" header in my reply. Thanks, Kevin > --- > include/mach-o/loader.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/include/mach-o/loader.h b/include/mach-o/loader.h > index c075a8e023..2c02102c9f 100644 > --- a/include/mach-o/loader.h > +++ b/include/mach-o/loader.h > @@ -174,8 +174,8 @@ typedef enum bfd_mach_o_load_command_type > BFD_MACH_O_LC_ENCRYPTION_INFO =3D 0x21, /* Encrypted segment info. */ > BFD_MACH_O_LC_DYLD_INFO =3D 0x22, /* Compressed dyld information. */ > BFD_MACH_O_LC_LOAD_UPWARD_DYLIB =3D 0x23, /* Load upward dylib. */ > - BFD_MACH_O_LC_VERSION_MIN_MACOSX =3D 0x24, /* Minimal MacOSX version= . */ > - BFD_MACH_O_LC_VERSION_MIN_IPHONEOS =3D 0x25, /* Minimal IOS version. = */ > + BFD_MACH_O_LC_VERSION_MIN_MACOSX =3D 0x24, /* Minimal macOS version.= */ > + BFD_MACH_O_LC_VERSION_MIN_IPHONEOS =3D 0x25, /* Minimal iOS version. = */ > BFD_MACH_O_LC_FUNCTION_STARTS =3D 0x26, /* Compressed table of func s= tart. */ > BFD_MACH_O_LC_DYLD_ENVIRONMENT =3D 0x27, /* Env variable string for dy= ld. */ > BFD_MACH_O_LC_MAIN =3D 0x28, /* Entry point. */ > @@ -185,7 +185,7 @@ typedef enum bfd_mach_o_load_command_type > BFD_MACH_O_LC_ENCRYPTION_INFO_64 =3D 0x2c, /* Encrypted 64 bit seg inf= o. */ > BFD_MACH_O_LC_LINKER_OPTIONS =3D 0x2d, /* Linker options. */ > BFD_MACH_O_LC_LINKER_OPTIMIZATION_HINT =3D 0x2e, /* Optimization hints= . */ > - BFD_MACH_O_LC_VERSION_MIN_WATCHOS =3D 0x30 /* Minimal WatchOS version.= */ > + BFD_MACH_O_LC_VERSION_MIN_WATCHOS =3D 0x30, /* Minimal watchOS version= . */ > } > bfd_mach_o_load_command_type; > =0C > --=20 > 2.19.1 >=20 >=20