* [PATCH] Use new Darwin operating system names
@ 2018-10-27 4:57 Saagar Jha
2019-02-15 2:13 ` Kevin Buettner
0 siblings, 1 reply; 6+ messages in thread
From: Saagar Jha @ 2018-10-27 4:57 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 145 bytes --]
I’ve taken the liberty to update the operating system names in include/mach-o/loader.h to use their modern spellings.
Regards,
Saagar Jha
[-- Attachment #2: Use-new-Darwin-operating-system-names.patch --]
[-- Type: application/octet-stream, Size: 1952 bytes --]
From bc2e3bc8c0cb1d4d407598952613ab12bfc167a8 Mon Sep 17 00:00:00 2001
From: Saagar Jha <saagar@saagarjha.com>
Date: Fri, 26 Oct 2018 04:44:28 -0700
Subject: [PATCH 2/5] Use new Darwin operating system names
Replace MacOSX with macOS, IOS with iOS, and WatchOS with watchOS.
ChangeLog:
2018-10-26 Saagar Jha <saagar@saagarjha.com>
* include/mach-o/loader.h: Use new OS names.
---
include/mach-o/loader.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/mach-o/loader.h b/include/mach-o/loader.h
index c075a8e023..2c02102c9f 100644
--- a/include/mach-o/loader.h
+++ b/include/mach-o/loader.h
@@ -174,8 +174,8 @@ typedef enum bfd_mach_o_load_command_type
BFD_MACH_O_LC_ENCRYPTION_INFO = 0x21, /* Encrypted segment info. */
BFD_MACH_O_LC_DYLD_INFO = 0x22, /* Compressed dyld information. */
BFD_MACH_O_LC_LOAD_UPWARD_DYLIB = 0x23, /* Load upward dylib. */
- BFD_MACH_O_LC_VERSION_MIN_MACOSX = 0x24, /* Minimal MacOSX version. */
- BFD_MACH_O_LC_VERSION_MIN_IPHONEOS = 0x25, /* Minimal IOS version. */
+ BFD_MACH_O_LC_VERSION_MIN_MACOSX = 0x24, /* Minimal macOS version. */
+ BFD_MACH_O_LC_VERSION_MIN_IPHONEOS = 0x25, /* Minimal iOS version. */
BFD_MACH_O_LC_FUNCTION_STARTS = 0x26, /* Compressed table of func start. */
BFD_MACH_O_LC_DYLD_ENVIRONMENT = 0x27, /* Env variable string for dyld. */
BFD_MACH_O_LC_MAIN = 0x28, /* Entry point. */
@@ -185,7 +185,7 @@ typedef enum bfd_mach_o_load_command_type
BFD_MACH_O_LC_ENCRYPTION_INFO_64 = 0x2c, /* Encrypted 64 bit seg info. */
BFD_MACH_O_LC_LINKER_OPTIONS = 0x2d, /* Linker options. */
BFD_MACH_O_LC_LINKER_OPTIMIZATION_HINT = 0x2e, /* Optimization hints. */
- BFD_MACH_O_LC_VERSION_MIN_WATCHOS = 0x30 /* Minimal WatchOS version. */
+ BFD_MACH_O_LC_VERSION_MIN_WATCHOS = 0x30, /* Minimal watchOS version. */
}
bfd_mach_o_load_command_type;
\f
--
2.19.1
[-- Attachment #3: Type: text/plain, Size: 1 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Use new Darwin operating system names
2018-10-27 4:57 [PATCH] Use new Darwin operating system names Saagar Jha
@ 2019-02-15 2:13 ` Kevin Buettner
2019-02-15 10:02 ` Nick Clifton
0 siblings, 1 reply; 6+ messages in thread
From: Kevin Buettner @ 2019-02-15 2:13 UTC (permalink / raw)
To: binutils, Saagar Jha; +Cc: gdb-patches
On Fri, 26 Oct 2018 21:57:37 -0700
Saagar Jha <saagar@saagarjha.com> wrote:
> Replace MacOSX with macOS, IOS with iOS, and WatchOS with watchOS.
>
> ChangeLog:
> 2018-10-26 Saagar Jha <saagar@saagarjha.com>
>
> * include/mach-o/loader.h: Use new OS names.
A couple of nits regarding the ChangeLog entry...
1) This entry should go in include/ChangeLog, so you don't need to
have the include/ prefix.
2) Please adjust it to indicate that only the comments are affected.
Like this, perhaps:
* mach-o/loader.h: Use new OS names in comments.
Otherwise, it looks good to me.
I wish I could tell you to check this in, but I think that the
binutils maintainers will need to approve this change. I've added
binutils@sourceware.org to the "To:" header in my reply.
Thanks,
Kevin
> ---
> include/mach-o/loader.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/mach-o/loader.h b/include/mach-o/loader.h
> index c075a8e023..2c02102c9f 100644
> --- a/include/mach-o/loader.h
> +++ b/include/mach-o/loader.h
> @@ -174,8 +174,8 @@ typedef enum bfd_mach_o_load_command_type
> BFD_MACH_O_LC_ENCRYPTION_INFO = 0x21, /* Encrypted segment info. */
> BFD_MACH_O_LC_DYLD_INFO = 0x22, /* Compressed dyld information. */
> BFD_MACH_O_LC_LOAD_UPWARD_DYLIB = 0x23, /* Load upward dylib. */
> - BFD_MACH_O_LC_VERSION_MIN_MACOSX = 0x24, /* Minimal MacOSX version. */
> - BFD_MACH_O_LC_VERSION_MIN_IPHONEOS = 0x25, /* Minimal IOS version. */
> + BFD_MACH_O_LC_VERSION_MIN_MACOSX = 0x24, /* Minimal macOS version. */
> + BFD_MACH_O_LC_VERSION_MIN_IPHONEOS = 0x25, /* Minimal iOS version. */
> BFD_MACH_O_LC_FUNCTION_STARTS = 0x26, /* Compressed table of func start. */
> BFD_MACH_O_LC_DYLD_ENVIRONMENT = 0x27, /* Env variable string for dyld. */
> BFD_MACH_O_LC_MAIN = 0x28, /* Entry point. */
> @@ -185,7 +185,7 @@ typedef enum bfd_mach_o_load_command_type
> BFD_MACH_O_LC_ENCRYPTION_INFO_64 = 0x2c, /* Encrypted 64 bit seg info. */
> BFD_MACH_O_LC_LINKER_OPTIONS = 0x2d, /* Linker options. */
> BFD_MACH_O_LC_LINKER_OPTIMIZATION_HINT = 0x2e, /* Optimization hints. */
> - BFD_MACH_O_LC_VERSION_MIN_WATCHOS = 0x30 /* Minimal WatchOS version. */
> + BFD_MACH_O_LC_VERSION_MIN_WATCHOS = 0x30, /* Minimal watchOS version. */
> }
> bfd_mach_o_load_command_type;
> \f
> --
> 2.19.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Use new Darwin operating system names
2019-02-15 2:13 ` Kevin Buettner
@ 2019-02-15 10:02 ` Nick Clifton
2019-02-15 10:49 ` Saagar Jha
0 siblings, 1 reply; 6+ messages in thread
From: Nick Clifton @ 2019-02-15 10:02 UTC (permalink / raw)
To: Kevin Buettner, binutils, Saagar Jha; +Cc: gdb-patches
Hi Saagar,
>
> 1) This entry should go in include/ChangeLog, so you don't need to
> have the include/ prefix.
>
> 2) Please adjust it to indicate that only the comments are affected.
> Like this, perhaps:
>
> * mach-o/loader.h: Use new OS names in comments.
>
> Otherwise, it looks good to me.
>
> I wish I could tell you to check this in, but I think that the
> binutils maintainers will need to approve this change. I've added
> binutils@sourceware.org to the "To:" header in my reply.
It is fine with the binutils too. So please apply with the changes
that Kevin has outlined.
Cheers
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Use new Darwin operating system names
2019-02-15 10:02 ` Nick Clifton
@ 2019-02-15 10:49 ` Saagar Jha
2019-02-15 12:52 ` Nick Clifton
0 siblings, 1 reply; 6+ messages in thread
From: Saagar Jha @ 2019-02-15 10:49 UTC (permalink / raw)
To: Nick Clifton; +Cc: Kevin Buettner, binutils, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 114 bytes --]
Here’s a new patch with the changes you’ve asked for. Let me know if you need anything else!
Saagar Jha
[-- Attachment #2: Use-new-Darwin-operating-system-names.patch --]
[-- Type: application/octet-stream, Size: 2056 bytes --]
From c1e3bddc43e2d4a7f3178024e57b8d75290a0e1d Mon Sep 17 00:00:00 2001
From: Saagar Jha <saagar@saagarjha.com>
Date: Fri, 26 Oct 2018 04:44:28 -0700
Subject: [PATCH] Use new Darwin operating system names
Replace MacOSX with macOS, IOS with iOS, and WatchOS with watchOS.
include/ChangeLog:
2019-02-15 Saagar Jha <saagar@saagarjha.com>
* mach-o/loader.h: Use new OS names in comments.
---
include/mach-o/loader.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/mach-o/loader.h b/include/mach-o/loader.h
index a870e50ba0..edf0a8becf 100644
--- a/include/mach-o/loader.h
+++ b/include/mach-o/loader.h
@@ -174,8 +174,8 @@ typedef enum bfd_mach_o_load_command_type
BFD_MACH_O_LC_ENCRYPTION_INFO = 0x21, /* Encrypted segment info. */
BFD_MACH_O_LC_DYLD_INFO = 0x22, /* Compressed dyld information. */
BFD_MACH_O_LC_LOAD_UPWARD_DYLIB = 0x23, /* Load upward dylib. */
- BFD_MACH_O_LC_VERSION_MIN_MACOSX = 0x24, /* Minimal MacOSX version. */
- BFD_MACH_O_LC_VERSION_MIN_IPHONEOS = 0x25, /* Minimal IOS version. */
+ BFD_MACH_O_LC_VERSION_MIN_MACOSX = 0x24, /* Minimal macOS version. */
+ BFD_MACH_O_LC_VERSION_MIN_IPHONEOS = 0x25, /* Minimal iOS version. */
BFD_MACH_O_LC_FUNCTION_STARTS = 0x26, /* Compressed table of func start. */
BFD_MACH_O_LC_DYLD_ENVIRONMENT = 0x27, /* Env variable string for dyld. */
BFD_MACH_O_LC_MAIN = 0x28, /* Entry point. */
@@ -186,7 +186,7 @@ typedef enum bfd_mach_o_load_command_type
BFD_MACH_O_LC_LINKER_OPTIONS = 0x2d, /* Linker options. */
BFD_MACH_O_LC_LINKER_OPTIMIZATION_HINT = 0x2e,/* Optimization hints. */
BFD_MACH_O_LC_VERSION_MIN_TVOS = 0x2f, /* Minimal tvOS version. */
- BFD_MACH_O_LC_VERSION_MIN_WATCHOS = 0x30, /* Minimal WatchOS version. */
+ BFD_MACH_O_LC_VERSION_MIN_WATCHOS = 0x30, /* Minimal watchOS version. */
BFD_MACH_O_LC_NOTE = 0x31, /* Region of arbitrary data. */
BFD_MACH_O_LC_BUILD_VERSION = 0x32, /* Generic build version. */
}
--
2.20.1
[-- Attachment #3: Type: text/plain, Size: 714 bytes --]
> On Feb 15, 2019, at 02:02, Nick Clifton <nickc@redhat.com> wrote:
>
> Hi Saagar,
>
>>
>> 1) This entry should go in include/ChangeLog, so you don't need to
>> have the include/ prefix.
>>
>> 2) Please adjust it to indicate that only the comments are affected.
>> Like this, perhaps:
>>
>> * mach-o/loader.h: Use new OS names in comments.
>>
>> Otherwise, it looks good to me.
>>
>> I wish I could tell you to check this in, but I think that the
>> binutils maintainers will need to approve this change. I've added
>> binutils@sourceware.org to the "To:" header in my reply.
>
> It is fine with the binutils too. So please apply with the changes
> that Kevin has outlined.
>
> Cheers
> Nick
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Use new Darwin operating system names
2019-02-15 10:49 ` Saagar Jha
@ 2019-02-15 12:52 ` Nick Clifton
0 siblings, 0 replies; 6+ messages in thread
From: Nick Clifton @ 2019-02-15 12:52 UTC (permalink / raw)
To: Saagar Jha; +Cc: Kevin Buettner, binutils, gdb-patches
Hi Saagar,
> Here’s a new patch with the changes you’ve asked for. Let me know if you need anything else!
I assume that you mean "please could this patch be applied to the sources in the repository"
so I have gone ahead and done that.
Cheers
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Use new Darwin operating system names
@ 2018-10-28 3:57 Saagar Jha
0 siblings, 0 replies; 6+ messages in thread
From: Saagar Jha @ 2018-10-28 3:57 UTC (permalink / raw)
To: binutils; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 145 bytes --]
I’ve taken the liberty to update the operating system names in include/mach-o/loader.h to use their modern spellings.
Regards,
Saagar Jha
[-- Attachment #2: Use-new-Darwin-operating-system-names.patch --]
[-- Type: application/octet-stream, Size: 1952 bytes --]
From bc2e3bc8c0cb1d4d407598952613ab12bfc167a8 Mon Sep 17 00:00:00 2001
From: Saagar Jha <saagar@saagarjha.com>
Date: Fri, 26 Oct 2018 04:44:28 -0700
Subject: [PATCH 2/5] Use new Darwin operating system names
Replace MacOSX with macOS, IOS with iOS, and WatchOS with watchOS.
ChangeLog:
2018-10-26 Saagar Jha <saagar@saagarjha.com>
* include/mach-o/loader.h: Use new OS names.
---
include/mach-o/loader.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/mach-o/loader.h b/include/mach-o/loader.h
index c075a8e023..2c02102c9f 100644
--- a/include/mach-o/loader.h
+++ b/include/mach-o/loader.h
@@ -174,8 +174,8 @@ typedef enum bfd_mach_o_load_command_type
BFD_MACH_O_LC_ENCRYPTION_INFO = 0x21, /* Encrypted segment info. */
BFD_MACH_O_LC_DYLD_INFO = 0x22, /* Compressed dyld information. */
BFD_MACH_O_LC_LOAD_UPWARD_DYLIB = 0x23, /* Load upward dylib. */
- BFD_MACH_O_LC_VERSION_MIN_MACOSX = 0x24, /* Minimal MacOSX version. */
- BFD_MACH_O_LC_VERSION_MIN_IPHONEOS = 0x25, /* Minimal IOS version. */
+ BFD_MACH_O_LC_VERSION_MIN_MACOSX = 0x24, /* Minimal macOS version. */
+ BFD_MACH_O_LC_VERSION_MIN_IPHONEOS = 0x25, /* Minimal iOS version. */
BFD_MACH_O_LC_FUNCTION_STARTS = 0x26, /* Compressed table of func start. */
BFD_MACH_O_LC_DYLD_ENVIRONMENT = 0x27, /* Env variable string for dyld. */
BFD_MACH_O_LC_MAIN = 0x28, /* Entry point. */
@@ -185,7 +185,7 @@ typedef enum bfd_mach_o_load_command_type
BFD_MACH_O_LC_ENCRYPTION_INFO_64 = 0x2c, /* Encrypted 64 bit seg info. */
BFD_MACH_O_LC_LINKER_OPTIONS = 0x2d, /* Linker options. */
BFD_MACH_O_LC_LINKER_OPTIMIZATION_HINT = 0x2e, /* Optimization hints. */
- BFD_MACH_O_LC_VERSION_MIN_WATCHOS = 0x30 /* Minimal WatchOS version. */
+ BFD_MACH_O_LC_VERSION_MIN_WATCHOS = 0x30, /* Minimal watchOS version. */
}
bfd_mach_o_load_command_type;
\f
--
2.19.1
[-- Attachment #3: Type: text/plain, Size: 1 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-15 12:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-27 4:57 [PATCH] Use new Darwin operating system names Saagar Jha
2019-02-15 2:13 ` Kevin Buettner
2019-02-15 10:02 ` Nick Clifton
2019-02-15 10:49 ` Saagar Jha
2019-02-15 12:52 ` Nick Clifton
2018-10-28 3:57 Saagar Jha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).