From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63262 invoked by alias); 17 Feb 2019 13:23:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63242 invoked by uid 89); 17 Feb 2019 13:23:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:454 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Feb 2019 13:23:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6C39F56057; Sun, 17 Feb 2019 08:22:59 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vk3YH0fzgMtf; Sun, 17 Feb 2019 08:22:59 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0CE9856055; Sun, 17 Feb 2019 08:22:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D97DF838C7; Sun, 17 Feb 2019 17:22:54 +0400 (+04) Date: Sun, 17 Feb 2019 13:23:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Add styling to macro commands Message-ID: <20190217132254.GB25164@adacore.com> References: <20190213125907.8571-1-tom@tromey.com> <20190213125907.8571-2-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190213125907.8571-2-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-02/txt/msg00266.txt.bz2 > This adds filename styling to "info macro". > > gdb/ChangeLog > 2019-02-13 Tom Tromey > > * macrocmd.c (show_pp_source_pos): Style the file names. > > gdb/testsuite/ChangeLog > 2019-02-13 Tom Tromey > > * gdb.base/style.exp: Use -g3 to compile when possible. Add test > for macro styling. > * gdb.base/style.c (SOME_MACRO): New macro. Hi Tom. Looks good to me. -- Joel