From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Change macro_source_fullname to return a std::string
Date: Sun, 17 Feb 2019 13:23:00 -0000 [thread overview]
Message-ID: <20190217132321.GC25164@adacore.com> (raw)
In-Reply-To: <20190213125907.8571-3-tom@tromey.com>
> While working on the previous patch, I noticed that if
> macro_source_fullname returned a std::string, then the callers would
> be simplified. This patch implements this idea.
Indeed!
> gdb/ChangeLog
> 2019-02-13 Tom Tromey <tom@tromey.com>
>
> * macrotab.h (macro_source_fullname): Return a std::string.
> * macrotab.c (macro_include, check_for_redefinition)
> (macro_undef, macro_lookup_definition, foreach_macro)
> (foreach_macro_in_scope): Update.
> (macro_source_fullname): Return a std::string.
> * macrocmd.c (show_pp_source_pos): Update.
The patch looks good also.
--
Joel
next prev parent reply other threads:[~2019-02-17 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 12:59 [PATCH 0/2] Styling + memory management in macro commands Tom Tromey
2019-02-13 12:59 ` [PATCH 2/2] Change macro_source_fullname to return a std::string Tom Tromey
2019-02-17 13:23 ` Joel Brobecker [this message]
2019-02-13 12:59 ` [PATCH 1/2] Add styling to macro commands Tom Tromey
2019-02-17 13:23 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190217132321.GC25164@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).