From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64199 invoked by alias); 17 Feb 2019 13:23:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64186 invoked by uid 89); 17 Feb 2019 13:23:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Feb 2019 13:23:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3175F56057; Sun, 17 Feb 2019 08:23:26 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kNxFPYFUO-H6; Sun, 17 Feb 2019 08:23:26 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C584B56055; Sun, 17 Feb 2019 08:23:25 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A4AAC838C7; Sun, 17 Feb 2019 17:23:21 +0400 (+04) Date: Sun, 17 Feb 2019 13:23:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Change macro_source_fullname to return a std::string Message-ID: <20190217132321.GC25164@adacore.com> References: <20190213125907.8571-1-tom@tromey.com> <20190213125907.8571-3-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190213125907.8571-3-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-02/txt/msg00267.txt.bz2 > While working on the previous patch, I noticed that if > macro_source_fullname returned a std::string, then the callers would > be simplified. This patch implements this idea. Indeed! > gdb/ChangeLog > 2019-02-13 Tom Tromey > > * macrotab.h (macro_source_fullname): Return a std::string. > * macrotab.c (macro_include, check_for_redefinition) > (macro_undef, macro_lookup_definition, foreach_macro) > (foreach_macro_in_scope): Update. > (macro_source_fullname): Return a std::string. > * macrocmd.c (show_pp_source_pos): Update. The patch looks good also. -- Joel