From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42045 invoked by alias); 19 Feb 2019 23:51:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42021 invoked by uid 89); 19 Feb 2019 23:51:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Feb 2019 23:51:33 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D78BF164C6D; Tue, 19 Feb 2019 23:51:31 +0000 (UTC) Received: from f29-4.lan (ovpn-117-11.phx2.redhat.com [10.3.117.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5069568D80; Tue, 19 Feb 2019 23:51:31 +0000 (UTC) Date: Tue, 19 Feb 2019 23:51:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Simon Marchi , Simon Marchi Subject: Re: [PATCH] Fix error message and use-after-free on errors in nested source files Message-ID: <20190219165130.67e94f6a@f29-4.lan> In-Reply-To: <7eed7ae3-6f2a-285b-1270-6006d524e87a@ericsson.com> References: <20190218234640.25664-1-simon.marchi@polymtl.ca> <20190219153729.35348891@f29-4.lan> <7eed7ae3-6f2a-285b-1270-6006d524e87a@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00319.txt.bz2 On Tue, 19 Feb 2019 23:24:01 +0000 Simon Marchi wrote: > > Did you mean to remove gdb_exit above? If so, why? > > Yes, many tests have a gdb_exit at the end. I believe this is not necessary (though it doesn't hurt) > because it's done anyway after the execution of the test. So it has become an automatism to remove > it if I am modifying that area of the tests. I can leave it there if you prefer. Thanks for the explanation. > Thanks for the review, here's the updated version. I also fixed the title, > where it should read "sourced" instead of "source". LGTM. Kevin