From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH v2 2/4] Define gdb.Value(bufobj, type) constructor
Date: Tue, 26 Feb 2019 17:34:00 -0000 [thread overview]
Message-ID: <20190226103424.555025cf@f29-4.lan> (raw)
In-Reply-To: <6e92c59bf470368dea2842e48254b8f8@polymtl.ca>
On Tue, 19 Feb 2019 22:43:09 -0500
Simon Marchi <simon.marchi@polymtl.ca> wrote:
> > + if (TYPE_LENGTH (type) > py_buf.len)
> > + {
> > + PyErr_SetString (PyExc_TypeError,
> > + _("Size of type is larger than that of buffer object."));
> > + return nullptr;
> > + }
>
> Another small thing I didn't spot when reading v1: I think it would be
> more appropriate to raise a ValueError in this last case. TypeError
> would be if the arguments were of the wrong Python type, which is not
> the case here. It just happens that the value we handle is a (GDB)
> type, but that's not the same kind of type. If you do that change,
> don't forget to update the tests as well.
I've made that change and have updated the test also.
Kevin
next prev parent reply other threads:[~2019-02-26 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 21:34 [PATCH v2 0/4] Define gdb.Value(val, " Kevin Buettner
2019-02-19 21:39 ` [PATCH v2 1/4] Define unique_ptr specialization for Py_buffer Kevin Buettner
2019-02-19 21:42 ` [PATCH v2 2/4] Define gdb.Value(bufobj, type) constructor Kevin Buettner
2019-02-20 3:43 ` Simon Marchi
2019-02-20 18:03 ` Tom Tromey
2019-02-26 17:34 ` Kevin Buettner [this message]
2019-02-19 21:43 ` [PATCH v2 3/4] Add tests for " Kevin Buettner
2019-02-19 21:46 ` [PATCH v2 4/4] Document two argument form of gdb.Value constructor Kevin Buettner
2019-02-20 3:35 ` Eli Zaretskii
2019-02-26 17:35 ` [PATCH v2 0/4] Define gdb.Value(val, type) constructor Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226103424.555025cf@f29-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).