public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix compilation using mingw.org's MinGW
Date: Thu, 18 Apr 2019 20:38:00 -0000	[thread overview]
Message-ID: <20190418133846.7dca95c2@f29-4.lan> (raw)
In-Reply-To: <83zhoncfg2.fsf@gnu.org>

On Thu, 18 Apr 2019 21:54:05 +0300
Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Thu, 18 Apr 2019 10:00:58 -0700
> > From: Kevin Buettner <kevinb@redhat.com>
> > Cc: gdb-patches@sourceware.org
> >   
> > > +#if _WIN32_WINNT < 0x0501
> > > +
> > > +typedef
> > > +struct _CONSOLE_FONT_INFO
> > > +{ DWORD 			nFont;
> > > +  COORD 			dwFontSize;
> > > +} CONSOLE_FONT_INFO, *PCONSOLE_FONT_INFO;
> > > +
> > > +#endif
> > > +
> > >  typedef BOOL WINAPI (AdjustTokenPrivileges_ftype) (HANDLE, BOOL,
> > >  						   PTOKEN_PRIVILEGES,
> > >  						   DWORD, PTOKEN_PRIVILEGES,  
> > 
> > I had expected to see a typedef for struct CONSOLE_FONT_INFO, but
> > instead see one for _CONSOLE_FONT_INFO (where the difference is
> > the leading underscore.)  
> 
> The struct is with the leading underscore, the typedef isn't.
> 
> > I'm guessing that there's some magic in Windows specific header files
> > which makes this work, but I just want to check to make sure that this
> > wasn't a typo on your part...  
> 
> It wasn't a typo, and there is no magic ;-)

Apologies - I clearly wasn't awake enough when I looked at your patch.

So... no objections from me regarding this patch.

Kevin

  reply	other threads:[~2019-04-18 20:38 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 15:36 Eli Zaretskii
2019-04-18 17:01 ` Kevin Buettner
2019-04-18 18:54   ` Eli Zaretskii
2019-04-18 20:38     ` Kevin Buettner [this message]
2019-04-19  6:19       ` Eli Zaretskii
2019-04-18 17:20 ` Pedro Alves
2019-04-18 17:22   ` Pedro Alves
2019-04-18 18:57     ` Eli Zaretskii
2019-04-19 10:51       ` Pedro Alves
2019-04-19 11:23         ` Eli Zaretskii
2019-04-19 11:33           ` Pedro Alves
2019-04-28 14:33             ` Eli Zaretskii
2019-04-30 12:56               ` Pedro Alves
2019-04-30 13:06                 ` LRN
2019-04-30 15:25                   ` Eli Zaretskii
2019-04-30 17:04                     ` Pedro Alves
2019-04-30 17:17                       ` Eli Zaretskii
2019-04-30 17:26                         ` Pedro Alves
2019-04-30 17:40                           ` Eli Zaretskii
2019-04-30 17:58                             ` Pedro Alves
2019-04-30 18:34                               ` Eli Zaretskii
2019-04-30 18:38                                 ` Pedro Alves
2019-04-30 17:50                     ` LRN
2019-04-30 13:10                 ` Pedro Alves
2019-04-30 15:23                   ` Eli Zaretskii
2019-04-30 16:31                     ` Pedro Alves
2019-05-03  8:04                       ` Eli Zaretskii
2019-05-03  8:26                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190418133846.7dca95c2@f29-4.lan \
    --to=kevinb@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).