From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Sergio Durigan Junior <sergiodj@redhat.com>
Subject: Re: [PATCH+8.3?] Implement dump of mappings with ELF headers by gcore
Date: Thu, 25 Apr 2019 21:04:00 -0000 [thread overview]
Message-ID: <20190425140431.37bd03fc@f29-4.lan> (raw)
In-Reply-To: <87mukec594.fsf@redhat.com>
On Thu, 25 Apr 2019 14:24:39 -0400
Sergio Durigan Junior <sergiodj@redhat.com> wrote:
> >> * linux-tdep.c (dump_mapping_p): Add new parameters "ADDR" and
> >> "OFFSET". Verify if current mapping contains an ELF header.
> >> (linux_find_memory_regions_full): Adjust call to
> >> "dump_mapping_p".
> >
> > I don't think that the double quotes enclosing ADDR and OFFSET are
> > needed here.
>
> Ah, OK. I tend to use them when I'm writing ChangeLog entries, but
> that's a matter of style. I'll remove them.
I think that quotes are appropriate when the actual names of the
parameters are used. But (as I recall) the GNU convention is to
change the names to all caps when referring to parameters in
documentation. ChangeLog entries are a form of documenation, so no
quotes.
So, had you said:
Add new parameters "addr" and "offset".
or:
Add new parameters ``addr'' and ``offset''.
...I would have been happy with the quotes.
But since you uppercased them, I don't think the quotes are needed
or even desired.
[...]
> > I think it's okay for master with the nits that I found fixed. I don't
> > have an opinion about including it in 8.3.
>
> Thanks, I pushed the patch below to master:
>
> 57e5e645010430b3d73f8c6a757d09f48dc8f8d5
I read your revised patch - didn't see any problems.
> I'll wait for another GM to give an opinion about including this into
> 8.3
If 8.3 is getting close, I think it should only go in master. But
if 8.3 still has some outstanding issues and testing yet to be done,
it might go in, especially if non-Fedora users are noticing problems.
Kevin
next prev parent reply other threads:[~2019-04-25 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 23:46 Sergio Durigan Junior
2019-04-25 17:21 ` Kevin Buettner
2019-04-25 18:24 ` Sergio Durigan Junior
2019-04-25 21:04 ` Kevin Buettner [this message]
2019-04-26 16:45 ` Sergio Durigan Junior
2019-04-26 16:48 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425140431.37bd03fc@f29-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).