From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36502 invoked by alias); 25 Apr 2019 21:04:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36491 invoked by uid 89); 25 Apr 2019 21:04:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=caps, outstanding X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Apr 2019 21:04:35 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB69B2DD76A for ; Thu, 25 Apr 2019 21:04:34 +0000 (UTC) Received: from f29-4.lan (ovpn-116-111.phx2.redhat.com [10.3.116.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A0E481001E8B; Thu, 25 Apr 2019 21:04:31 +0000 (UTC) Date: Thu, 25 Apr 2019 21:04:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Sergio Durigan Junior Subject: Re: [PATCH+8.3?] Implement dump of mappings with ELF headers by gcore Message-ID: <20190425140431.37bd03fc@f29-4.lan> In-Reply-To: <87mukec594.fsf@redhat.com> References: <20190423234635.26916-1-sergiodj@redhat.com> <20190425102100.08da12eb@f29-4.lan> <87mukec594.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00569.txt.bz2 On Thu, 25 Apr 2019 14:24:39 -0400 Sergio Durigan Junior wrote: > >> * linux-tdep.c (dump_mapping_p): Add new parameters "ADDR" and > >> "OFFSET". Verify if current mapping contains an ELF header. > >> (linux_find_memory_regions_full): Adjust call to > >> "dump_mapping_p". > > > > I don't think that the double quotes enclosing ADDR and OFFSET are > > needed here. > > Ah, OK. I tend to use them when I'm writing ChangeLog entries, but > that's a matter of style. I'll remove them. I think that quotes are appropriate when the actual names of the parameters are used. But (as I recall) the GNU convention is to change the names to all caps when referring to parameters in documentation. ChangeLog entries are a form of documenation, so no quotes. So, had you said: Add new parameters "addr" and "offset". or: Add new parameters ``addr'' and ``offset''. ...I would have been happy with the quotes. But since you uppercased them, I don't think the quotes are needed or even desired. [...] > > I think it's okay for master with the nits that I found fixed. I don't > > have an opinion about including it in 8.3. > > Thanks, I pushed the patch below to master: > > 57e5e645010430b3d73f8c6a757d09f48dc8f8d5 I read your revised patch - didn't see any problems. > I'll wait for another GM to give an opinion about including this into > 8.3 If 8.3 is getting close, I think it should only go in master. But if 8.3 still has some outstanding issues and testing yet to be done, it might go in, especially if non-Fedora users are noticing problems. Kevin