GDB 8.3 release update (2019-04-30)

GDB 8.3 release update (2019-04-30)

[Joel Brobecker]

Hello,

I think the following got fixed since the last update:

   * [TomT] Control characters in source causes infinite loop
     https://sourceware.org/ml/gdb-patches/2019-03/msg00611.html

     Fixed by: Fix "list" when control characters are seen
     https://www.sourceware.org/ml/gdb-patches/2019-04/msg00158.html

   * [JoelB] GDB crash on Windows native
     https://www.sourceware.org/ml/gdb-patches/2019-04/msg00279.html

Are there any other issues that would be blocking before we create
the GDB 8.3 release?

   - I heard that there might be one known issue with styling
     that Tom tried to look at but couldn't reproduce?

   - I also see that we have the following patch waiting for review:

       [PATCH + 8.3] Don't derive partial_symbol from general_symbol_info
       https://www.sourceware.org/ml/gdb-patches/2019-04/msg00489.html

     The patch seems simple and safe, but I would need more study time
     to convince myself that there aren't other approaches that might
     be more interesting to take. Was anyone planning on reviewing it?

Anything else I might have missed?

Thanks you!
-- 
Joel

Re: GDB 8.3 release update (2019-04-30)

[Eli Zaretskii]

> Date: Tue, 30 Apr 2019 14:22:24 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> I think the following got fixed since the last update:
> 
>    * [TomT] Control characters in source causes infinite loop
>      https://sourceware.org/ml/gdb-patches/2019-03/msg00611.html
> 
>      Fixed by: Fix "list" when control characters are seen
>      https://www.sourceware.org/ml/gdb-patches/2019-04/msg00158.html
> 
>    * [JoelB] GDB crash on Windows native
>      https://www.sourceware.org/ml/gdb-patches/2019-04/msg00279.html
> 
> Are there any other issues that would be blocking before we create
> the GDB 8.3 release?
> 
>    - I heard that there might be one known issue with styling
>      that Tom tried to look at but couldn't reproduce?
> 
>    - I also see that we have the following patch waiting for review:
> 
>        [PATCH + 8.3] Don't derive partial_symbol from general_symbol_info
>        https://www.sourceware.org/ml/gdb-patches/2019-04/msg00489.html
> 
>      The patch seems simple and safe, but I would need more study time
>      to convince myself that there aren't other approaches that might
>      be more interesting to take. Was anyone planning on reviewing it?
> 
> Anything else I might have missed?

I'd like to fix the problem with constructing the directory of
separate debug info on Windows, and also fix the compilation problem
with CONSOLE_FONT_INFO.  I intend to push changes for both in the next
couple of days.

Re: GDB 8.3 release update (2019-04-30)

[Tom Tromey]

Joel>    - I heard that there might be one known issue with styling
Joel>      that Tom tried to look at but couldn't reproduce?

I'll try again today.

Joel>    - I also see that we have the following patch waiting for review:

Joel>        [PATCH + 8.3] Don't derive partial_symbol from general_symbol_info
Joel>        https://www.sourceware.org/ml/gdb-patches/2019-04/msg00489.html

Joel>      The patch seems simple and safe, but I would need more study time
Joel>      to convince myself that there aren't other approaches that might
Joel>      be more interesting to take. Was anyone planning on reviewing it?

It's a partial revert of an earlier patch, and it fixes some valgrind
errors on the Fedora-i686 buildbot, so I think the default ought to be
to check it in.

Tom

Re: GDB 8.3 release update (2019-04-30)

[Eli Zaretskii]

> Date: Wed, 01 May 2019 05:45:07 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> CC: gdb-patches@sourceware.org
> 
> > Anything else I might have missed?
> 
> I'd like to fix the problem with constructing the directory of
> separate debug info on Windows, and also fix the compilation problem
> with CONSOLE_FONT_INFO.  I intend to push changes for both in the next
> couple of days.

Both issues now fixed on both the master and the 8.3 branch.

Thanks.

Re: GDB 8.3 release update (2019-04-30)

[Joel Brobecker]

> > I'd like to fix the problem with constructing the directory of
> > separate debug info on Windows, and also fix the compilation problem
> > with CONSOLE_FONT_INFO.  I intend to push changes for both in the next
> > couple of days.
> 
> Both issues now fixed on both the master and the 8.3 branch.

Excellent, thanks for letting me know. Tom and I will try to have
the patches from master going through our nightly testing over
the weekend, to see if AdaCore's testsuite picks anything up.

-- 
Joel