public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/5] pipe command completer, and string options
Date: Thu, 27 Jun 2019 19:14:00 -0000	[thread overview]
Message-ID: <20190627191427.20742-1-palves@redhat.com> (raw)

Tromey noticed that the "pipe" command doesn't have a completer.
Initially I said I wasn't planning on looking at it, thinking that all
the building blocks were already in place.  But I quickly realized
that there's one piece missing -- string options...  So I took a stab
at implementing it.  Of course, lucky me, I ran into other issues and
latent bugs, now all addressed...

Pedro Alves (5):
  Fix test_gdb_complete_tab_multiple race
  Make gdb::option::complete_options save processed arguments too
  Teach gdb::option about string options
  Fix latent bug in test_gdb_complete_cmd_multiple
  pipe command completer

 gdb/cli/cli-cmds.c                       |  92 +++++++++++++--
 gdb/cli/cli-option.c                     | 157 ++++++++++++++++++++-----
 gdb/cli/cli-option.h                     |  21 ++++
 gdb/cli/cli-utils.c                      |   7 +-
 gdb/maint-test-options.c                 | 134 ++++++++++++++--------
 gdb/testsuite/gdb.base/options.exp       | 190 +++++++++++++++++++++++--------
 gdb/testsuite/gdb.base/shell.exp         |  47 +++++++-
 gdb/testsuite/lib/completion-support.exp |  11 +-
 8 files changed, 522 insertions(+), 137 deletions(-)

-- 
2.14.5

             reply	other threads:[~2019-06-27 19:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 19:14 Pedro Alves [this message]
2019-06-27 19:14 ` [PATCH 5/5] pipe command completer Pedro Alves
2019-06-28 15:16   ` Tom Tromey
2019-07-03 16:28     ` Pedro Alves
2019-06-27 19:14 ` [PATCH 2/5] Make gdb::option::complete_options save processed arguments too Pedro Alves
2019-06-27 19:14 ` [PATCH 3/5] Teach gdb::option about string options Pedro Alves
2019-06-28 15:11   ` Tom Tromey
2019-07-03 16:25     ` Pedro Alves
2019-06-27 19:14 ` [PATCH 4/5] Fix latent bug in test_gdb_complete_cmd_multiple Pedro Alves
2019-06-28 14:53   ` Tom Tromey
2019-06-28 14:56     ` Pedro Alves
2019-06-28 15:46       ` Tom Tromey
2019-06-27 19:14 ` [PATCH 1/5] Fix test_gdb_complete_tab_multiple race Pedro Alves
2019-06-28 15:16 ` [PATCH 0/5] pipe command completer, and string options Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627191427.20742-1-palves@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).