From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85261 invoked by alias); 27 Jun 2019 19:14:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85248 invoked by uid 89); 27 Jun 2019 19:14:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=UD:options.exp, options.exp, optionsexp, lucky X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jun 2019 19:14:30 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 11E493001822 for ; Thu, 27 Jun 2019 19:14:29 +0000 (UTC) Received: from localhost.localdomain (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 97FA360126 for ; Thu, 27 Jun 2019 19:14:28 +0000 (UTC) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 0/5] pipe command completer, and string options Date: Thu, 27 Jun 2019 19:14:00 -0000 Message-Id: <20190627191427.20742-1-palves@redhat.com> X-SW-Source: 2019-06/txt/msg00621.txt.bz2 Tromey noticed that the "pipe" command doesn't have a completer. Initially I said I wasn't planning on looking at it, thinking that all the building blocks were already in place. But I quickly realized that there's one piece missing -- string options... So I took a stab at implementing it. Of course, lucky me, I ran into other issues and latent bugs, now all addressed... Pedro Alves (5): Fix test_gdb_complete_tab_multiple race Make gdb::option::complete_options save processed arguments too Teach gdb::option about string options Fix latent bug in test_gdb_complete_cmd_multiple pipe command completer gdb/cli/cli-cmds.c | 92 +++++++++++++-- gdb/cli/cli-option.c | 157 ++++++++++++++++++++----- gdb/cli/cli-option.h | 21 ++++ gdb/cli/cli-utils.c | 7 +- gdb/maint-test-options.c | 134 ++++++++++++++-------- gdb/testsuite/gdb.base/options.exp | 190 +++++++++++++++++++++++-------- gdb/testsuite/gdb.base/shell.exp | 47 +++++++- gdb/testsuite/lib/completion-support.exp | 11 +- 8 files changed, 522 insertions(+), 137 deletions(-) -- 2.14.5