From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/8] Add test for "layout asm"
Date: Fri, 26 Jul 2019 11:11:00 -0000 [thread overview]
Message-ID: <20190726111130.GK23204@embecosm.com> (raw)
In-Reply-To: <20190721184910.26679-3-tom@tromey.com>
* Tom Tromey <tom@tromey.com> [2019-07-21 12:49:04 -0600]:
> This adds a very simple test for "layout asm".
>
> gdb/testsuite/ChangeLog
> 2019-07-21 Tom Tromey <tom@tromey.com>
>
> * gdb.tui/basic.exp: Add "layout asm" test.
> ---
> gdb/testsuite/ChangeLog | 4 ++++
> gdb/testsuite/gdb.tui/basic.exp | 10 ++++++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.tui/basic.exp b/gdb/testsuite/gdb.tui/basic.exp
> index 48d39741ba5..1eeeaa77606 100644
> --- a/gdb/testsuite/gdb.tui/basic.exp
> +++ b/gdb/testsuite/gdb.tui/basic.exp
> @@ -47,3 +47,13 @@ if {[regexp "21 *return 0" $text]} {
> # box.
> setup_xfail *-*-*
> Term::check_box "source box" 3 0 77 15
> +
> +Term::command "layout asm"
> +set text [Term::get_all_lines]
> +if {[regexp "$hex <main>" $text]} {
> + pass "asm window shows main"
> +} else {
> + fail "asm window shows main"
> +}
Wow! This is awesome! Hopefully this can really drive TUI testing
forward.
I noticed this pattern a lot in this series, I wonder if using
'gdb_assert' would be cleaner?
It even returns true/false so you can do (looking at patch #5 if in
the series):
if {![gdb_assert {[...condition]} "test name"]} {
Term::dump_screen
}
Thanks,
Andrew
> +
> +Term::check_box "asm box" 3 0 77 15
> --
> 2.17.2
>
next prev parent reply other threads:[~2019-07-26 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 18:49 [PATCH 0/8] Testing for the TUI Tom Tromey
2019-07-21 18:49 ` [PATCH 6/8] Add TUI resizing test Tom Tromey
2019-07-21 18:49 ` [PATCH 5/8] Add TUI test for "list" Tom Tromey
2019-07-21 18:49 ` [PATCH 3/8] Add "layout split" test Tom Tromey
2019-07-21 18:49 ` [PATCH 2/8] Add test for "layout asm" Tom Tromey
2019-07-26 11:11 ` Andrew Burgess [this message]
2019-07-26 18:50 ` Tom Tromey
2019-07-21 18:49 ` [PATCH 1/8] A virtual terminal for the test suite Tom Tromey
2019-07-21 18:49 ` [PATCH 7/8] Add test case for empty TUI windows Tom Tromey
2019-07-21 18:49 ` [PATCH 8/8] Add test that "file" shows "main" Tom Tromey
2019-07-21 18:49 ` [PATCH 4/8] Add TUI register window test Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726111130.GK23204@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).