From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 3/8] Remove gdb workaround from readline/emacs_keymap.c
Date: Tue, 06 Aug 2019 20:43:00 -0000 [thread overview]
Message-ID: <20190806204334.13441-4-tom@tromey.com> (raw)
In-Reply-To: <20190806204334.13441-1-tom@tromey.com>
There is a gdb-local patch in readline/emacs_keymap.c that says:
/* Temporary - this is a bug in readline 5.1 that should be fixed in
readline 5.2. */
So, I think this can be removed now. I have no way to test this, as
the patch was specific to mingw.
2018-10-07 Tom Tromey <tom@tromey.com>
* emacs_keymap.c: Remove gdb workaround.
---
readline/ChangeLog.gdb | 4 ++++
readline/emacs_keymap.c | 6 ------
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/readline/emacs_keymap.c b/readline/emacs_keymap.c
index 9f816581efa..cb6e140a217 100644
--- a/readline/emacs_keymap.c
+++ b/readline/emacs_keymap.c
@@ -277,13 +277,7 @@ KEYMAP_ENTRY_ARRAY emacs_standard_keymap = {
{ ISFUNC, rl_insert }, /* Latin capital letter Y with acute */
{ ISFUNC, rl_insert }, /* Latin capital letter thorn (Icelandic) */
{ ISFUNC, rl_insert }, /* Latin small letter sharp s (German) */
-#ifndef __MINGW32__
{ ISFUNC, rl_insert }, /* Latin small letter a with grave */
-#else
- /* Temporary - this is a bug in readline 5.1 that should be fixed in
- readline 5.2. */
- { ISFUNC, 0 }, /* Must leave this unbound for the arrow keys to work. */
-#endif
{ ISFUNC, rl_insert }, /* Latin small letter a with acute */
{ ISFUNC, rl_insert }, /* Latin small letter a with circumflex */
{ ISFUNC, rl_insert }, /* Latin small letter a with tilde */
--
2.17.2
next prev parent reply other threads:[~2019-08-06 20:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 20:43 [PATCH 0/8] Upgrade readline Tom Tromey
2019-08-06 20:43 ` [PATCH 5/8] Fix gdb's selftest.exp after readline import Tom Tromey
2019-08-13 17:02 ` [committed][gdb/testsuite] Fix gdb.gdb/selftest.exp regexp Tom de Vries
2019-08-06 20:43 ` [PATCH 7/8] Remove readline hack from gdb_select Tom Tromey
2019-08-07 14:29 ` Pedro Alves
2019-08-07 22:03 ` Tom Tromey
2019-08-07 22:16 ` Christian Biesinger via gdb-patches
2019-08-06 20:43 ` Tom Tromey [this message]
2019-08-06 20:43 ` [PATCH 4/8] Remove gdb workaround from readline/xfree.c Tom Tromey
2019-08-06 20:43 ` [PATCH 8/8] Require readline 7 or newer Tom Tromey
2019-08-07 2:27 ` Eli Zaretskii
2019-08-07 14:42 ` Pedro Alves
2019-08-07 22:31 ` Tom Tromey
2019-08-08 2:37 ` Eli Zaretskii
2019-08-08 11:26 ` Pedro Alves
2019-08-08 11:29 ` Pedro Alves
2019-08-08 20:38 ` Tom Tromey
2019-08-07 14:45 ` Pedro Alves
2019-08-06 20:43 ` [PATCH 2/8] Remove gdb workaround from readline/complete.c Tom Tromey
2019-08-07 3:05 ` [PATCH 0/8] Upgrade readline Kevin Buettner
2019-08-07 13:38 ` Tom Tromey
2019-08-07 13:40 ` Tom Tromey
2019-08-14 10:21 ` Tom de Vries
2019-08-15 13:46 ` Tom Tromey
2019-08-19 16:38 ` Tom de Vries
2019-08-07 16:32 ` Sergio Durigan Junior
2019-08-07 19:31 ` Tom Tromey
2019-08-12 19:46 ` Sergio Durigan Junior
2019-08-12 19:52 ` Christian Biesinger via gdb-patches
2019-08-12 16:57 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806204334.13441-4-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).