From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Simplify write_inferior_memory
Date: Thu, 15 Aug 2019 01:59:00 -0000 [thread overview]
Message-ID: <20190814185932.164f2a69@f29-4.lan> (raw)
In-Reply-To: <20190814164814.29367-2-tromey@adacore.com>
On Wed, 14 Aug 2019 10:48:13 -0600
Tom Tromey <tromey@adacore.com> wrote:
> gdbserver's write_inferior_memory uses a static variable to avoid
> memory leaks, and has a comment referring to the lack of cleanups.
> This patch removes this comment and the code in favor of a
> straightforward use of std::vector.
>
> gdb/gdbserver/ChangeLog
> 2019-08-14 Tom Tromey <tromey@adacore.com>
>
> * target.c (write_inferior_memory): Use std::vector.
LGTM.
Kevin
next prev parent reply other threads:[~2019-08-15 1:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 16:48 [PATCH 0/2] Small memory-writing gdbserver improvements Tom Tromey
2019-08-14 16:48 ` [PATCH 1/2] Simplify write_inferior_memory Tom Tromey
2019-08-15 1:59 ` Kevin Buettner [this message]
2019-08-15 15:51 ` Pedro Alves
2019-08-15 17:22 ` Tom Tromey
2019-08-14 16:48 ` [PATCH 2/2] Replace write_inferior_memory with target_write_memory Tom Tromey
2019-08-15 2:28 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814185932.164f2a69@f29-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).