* [FYI] Use gdb::byte_vector in target_write_memory
@ 2019-08-15 17:23 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2019-08-15 17:23 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
Pedro pointed out that target_write_memory should use gdb::byte_vector
rather than std::vector<unsigned char>.
gdb/gdbserver/ChangeLog
2019-08-15 Tom Tromey <tromey@adacore.com>
* target.c (target_write_memory): Use gdb::byte_vector.
---
gdb/gdbserver/ChangeLog | 4 ++++
gdb/gdbserver/target.c | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/gdbserver/target.c b/gdb/gdbserver/target.c
index 6f6b448ecf4..0b45b6c956d 100644
--- a/gdb/gdbserver/target.c
+++ b/gdb/gdbserver/target.c
@@ -20,6 +20,7 @@
#include "server.h"
#include "tracepoint.h"
+#include "gdbsupport/byte-vector.h"
struct target_ops *the_target;
@@ -154,7 +155,7 @@ target_write_memory (CORE_ADDR memaddr, const unsigned char *myaddr,
{
/* Make a copy of the data because check_mem_write may need to
update it. */
- std::vector<unsigned char> buffer (myaddr, myaddr + len);
+ gdb::byte_vector buffer (myaddr, myaddr + len);
check_mem_write (memaddr, buffer.data (), myaddr, len);
return (*the_target->write_memory) (memaddr, buffer.data (), len);
}
--
2.20.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-08-15 17:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 17:23 [FYI] Use gdb::byte_vector in target_write_memory Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).