From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74613 invoked by alias); 16 Aug 2019 16:15:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73975 invoked by uid 89); 16 Aug 2019 16:15:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Aug 2019 16:15:25 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 9F076F911B for ; Fri, 16 Aug 2019 11:15:14 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id yeskhZWTO3Qi0yeskhGy7t; Fri, 16 Aug 2019 11:15:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9ClD5k1O8ZC93p0hLN+0qzJKjJZKCEAKAxO/SbDy2cQ=; b=Yp4H9nZrhC2VJzQaCwoD/mnbPp jQW6B/47a7e2smlXCdEpYzz2m4kCOhQdlsEURFsgH7qC0eitYjWmd01q7e0DKf3ztGRsKl70qEB+Q SI1jgo/z8//imyYiNJ/gDR4BP; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:40466 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hyesk-002SJK-Df; Fri, 16 Aug 2019 11:15:14 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 3/9] Remove "noerror" parameter from some TUI functions Date: Fri, 16 Aug 2019 16:15:00 -0000 Message-Id: <20190816161511.16162-4-tom@tromey.com> In-Reply-To: <20190816161511.16162-1-tom@tromey.com> References: <20190816161511.16162-1-tom@tromey.com> X-SW-Source: 2019-08/txt/msg00365.txt.bz2 A few TUI functions take a "noerror" parameter. This is only checked in one spot: in tui_set_source_content, if noerror is false, and if an error occurs, then the function will call print_sys_errmsg. This seems misguided to me, so this patch removes that code and this parameter. gdb/ChangeLog 2019-08-16 Tom Tromey * tui/tui-winsource.h (tui_update_source_window) (tui_update_source_window_as_is): Remove "noerror" parameter. * tui/tui-winsource.c (tui_update_source_window) (tui_update_source_window_as_is): Remove "noerror" parameter. (tui_update_source_windows_with_addr) (tui_update_source_windows_with_line) (tui_source_window_base::rerender) (tui_source_window_base::refill): Update. * tui/tui-source.h (tui_set_source_content) (tui_show_symtab_source): Remove "noerror" parameter. * tui/tui-source.c (tui_set_source_content): Remove "noerror" parameter. (tui_show_symtab_source): Likewise. (tui_source_window::maybe_update): Update. * tui/tui-disasm.c (tui_show_disassem) (tui_show_disassem_and_update_source) (tui_disasm_window::do_scroll_vertical) (tui_disasm_window::maybe_update): Update. --- gdb/ChangeLog | 21 +++++++++++++++++++++ gdb/tui/tui-disasm.c | 8 ++++---- gdb/tui/tui-source.c | 22 +++++----------------- gdb/tui/tui-source.h | 5 ++--- gdb/tui/tui-winsource.c | 22 +++++++++------------- gdb/tui/tui-winsource.h | 6 ++---- 6 files changed, 43 insertions(+), 41 deletions(-) diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index 3ebe303f751..621832ff92a 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -257,7 +257,7 @@ tui_show_disassem (struct gdbarch *gdbarch, CORE_ADDR start_addr) val.loa = LOA_ADDRESS; val.u.addr = start_addr; - tui_update_source_window (TUI_DISASM_WIN, gdbarch, s, val, FALSE); + tui_update_source_window (TUI_DISASM_WIN, gdbarch, s, val); /* If the focus was in the src win, put it in the asm win, if the source view isn't split. */ @@ -285,7 +285,7 @@ tui_show_disassem_and_update_source (struct gdbarch *gdbarch, sal = find_pc_line (start_addr, 0); val.loa = LOA_LINE; val.u.line_no = sal.line; - tui_update_source_window (TUI_SRC_WIN, gdbarch, sal.symtab, val, TRUE); + tui_update_source_window (TUI_SRC_WIN, gdbarch, sal.symtab, val); if (sal.symtab) { set_current_source_symtab_and_line (sal); @@ -368,7 +368,7 @@ tui_disasm_window::do_scroll_vertical (int num_to_scroll) val.loa = LOA_ADDRESS; val.u.addr = tui_find_disassembly_address (gdbarch, pc, num_to_scroll); tui_update_source_window_as_is (this, gdbarch, - NULL, val, FALSE); + NULL, val); } } @@ -420,7 +420,7 @@ tui_disasm_window::maybe_update (struct frame_info *fi, symtab_and_line sal, a.u.addr = low; if (!addr_is_displayed (addr)) tui_update_source_window (this, get_frame_arch (fi), - sal.symtab, a, TRUE); + sal.symtab, a); else { a.u.addr = addr; diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c index c86af84423e..db83fb01138 100644 --- a/gdb/tui/tui-source.c +++ b/gdb/tui/tui-source.c @@ -125,8 +125,7 @@ copy_source_line (const char **ptr, int line_no, int first_col, enum tui_status tui_set_source_content (tui_source_window_base *win_info, struct symtab *s, - int line_no, - int noerror) + int line_no) { enum tui_status ret = TUI_FAILURE; @@ -143,17 +142,7 @@ tui_set_source_content (tui_source_window_base *win_info, std::string srclines; if (!g_source_cache.get_source_lines (s, line_no, line_no + nlines, &srclines)) - { - if (!noerror) - { - const char *filename = symtab_to_filename_for_display (s); - char *name = (char *) alloca (strlen (filename) + 100); - - sprintf (name, "%s:%d", filename, line_no); - print_sys_errmsg (name, errno); - } - ret = TUI_FAILURE; - } + ret = TUI_FAILURE; else { int cur_line_no, cur_line; @@ -213,11 +202,10 @@ tui_set_source_content (tui_source_window_base *win_info, void tui_show_symtab_source (tui_source_window_base *win_info, struct gdbarch *gdbarch, struct symtab *s, - struct tui_line_or_address line, - int noerror) + struct tui_line_or_address line) { win_info->horizontal_offset = 0; - tui_update_source_window_as_is (win_info, gdbarch, s, line, noerror); + tui_update_source_window_as_is (win_info, gdbarch, s, line); } @@ -330,7 +318,7 @@ tui_source_window::maybe_update (struct frame_info *fi, symtab_and_line sal, if (!(source_already_displayed && line_is_displayed (line_no))) tui_update_source_window (this, get_frame_arch (fi), - sal.symtab, l, TRUE); + sal.symtab, l); else { l.u.line_no = line_no; diff --git a/gdb/tui/tui-source.h b/gdb/tui/tui-source.h index 2926777ab3f..1d7af2aad83 100644 --- a/gdb/tui/tui-source.h +++ b/gdb/tui/tui-source.h @@ -74,10 +74,9 @@ private: extern enum tui_status tui_set_source_content (tui_source_window_base *, struct symtab *, - int, int); + int); extern void tui_show_symtab_source (tui_source_window_base *, struct gdbarch *, struct symtab *, - struct tui_line_or_address, - int); + struct tui_line_or_address); #endif /* TUI_TUI_SOURCE_H */ diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c index b6ce652d09d..94ab8c09f67 100644 --- a/gdb/tui/tui-winsource.c +++ b/gdb/tui/tui-winsource.c @@ -73,11 +73,10 @@ void tui_update_source_window (struct tui_source_window_base *win_info, struct gdbarch *gdbarch, struct symtab *s, - struct tui_line_or_address line_or_addr, - int noerror) + struct tui_line_or_address line_or_addr) { win_info->horizontal_offset = 0; - tui_update_source_window_as_is (win_info, gdbarch, s, line_or_addr, noerror); + tui_update_source_window_as_is (win_info, gdbarch, s, line_or_addr); } @@ -87,14 +86,12 @@ void tui_update_source_window_as_is (struct tui_source_window_base *win_info, struct gdbarch *gdbarch, struct symtab *s, - struct tui_line_or_address line_or_addr, - int noerror) + struct tui_line_or_address line_or_addr) { enum tui_status ret; if (win_info->type == SRC_WIN) - ret = tui_set_source_content (win_info, s, line_or_addr.u.line_no, - noerror); + ret = tui_set_source_content (win_info, s, line_or_addr.u.line_no); else ret = tui_set_disassem_content (win_info, gdbarch, line_or_addr.u.addr); @@ -147,7 +144,7 @@ tui_update_source_windows_with_addr (struct gdbarch *gdbarch, CORE_ADDR addr) sal = find_pc_line (addr, 0); l.loa = LOA_LINE; l.u.line_no = sal.line; - tui_show_symtab_source (TUI_SRC_WIN, gdbarch, sal.symtab, l, FALSE); + tui_show_symtab_source (TUI_SRC_WIN, gdbarch, sal.symtab, l); break; } } @@ -182,7 +179,7 @@ tui_update_source_windows_with_line (struct symtab *s, int line) default: l.loa = LOA_LINE; l.u.line_no = line; - tui_show_symtab_source (TUI_SRC_WIN, gdbarch, s, l, FALSE); + tui_show_symtab_source (TUI_SRC_WIN, gdbarch, s, l); if (tui_current_layout () == SRC_DISASSEM_COMMAND) { find_line_pc (s, line, &pc); @@ -330,7 +327,7 @@ tui_source_window_base::rerender () line_or_addr = start_line_or_addr; tui_update_source_window (this, gdbarch, - cursal.symtab, line_or_addr, TRUE); + cursal.symtab, line_or_addr); } else if (deprecated_safe_get_selected_frame () != NULL) { @@ -351,7 +348,7 @@ tui_source_window_base::rerender () line.loa = LOA_ADDRESS; find_line_pc (s, cursal.line, &line.u.addr); } - tui_update_source_window (this, gdbarch, s, line, TRUE); + tui_update_source_window (this, gdbarch, s, line); } else erase_source_content (); @@ -391,8 +388,7 @@ tui_source_window_base::refill () } tui_update_source_window_as_is (this, gdbarch, s, - content[0].line_or_addr, - FALSE); + content[0].line_or_addr); } /* Scroll the source forward or backward horizontally. */ diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h index a4167f50d7a..dfd4a0002a8 100644 --- a/gdb/tui/tui-winsource.h +++ b/gdb/tui/tui-winsource.h @@ -245,12 +245,10 @@ extern bool tui_update_breakpoint_info (struct tui_source_window_base *win, extern void tui_display_main (void); extern void tui_update_source_window (struct tui_source_window_base *, struct gdbarch *, struct symtab *, - struct tui_line_or_address, - int); + struct tui_line_or_address); extern void tui_update_source_window_as_is (struct tui_source_window_base *, struct gdbarch *, struct symtab *, - struct tui_line_or_address, - int); + struct tui_line_or_address); extern void tui_update_source_windows_with_addr (struct gdbarch *, CORE_ADDR); extern void tui_update_source_windows_with_line (struct symtab *, int); -- 2.17.2