From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 12/15] Make tui_locator_window::set_locator_fullname re-render
Date: Wed, 21 Aug 2019 02:25:00 -0000 [thread overview]
Message-ID: <20190821022535.9762-13-tom@tromey.com> (raw)
In-Reply-To: <20190821022535.9762-1-tom@tromey.com>
This changes tui_locator_window::set_locator_fullname to re-render the
locator window, so that the callers don't need to do this.
gdb/ChangeLog
2019-08-20 Tom Tromey <tom@tromey.com>
* tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
rerender.
(tui_update_locator_fullname, tui_show_frame_info): Don't call
tui_show_locator_content.
---
gdb/ChangeLog | 7 +++++++
gdb/tui/tui-stack.c | 4 +---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/gdb/tui/tui-stack.c b/gdb/tui/tui-stack.c
index 48062fed712..f6b6bb72b2a 100644
--- a/gdb/tui/tui-stack.c
+++ b/gdb/tui/tui-stack.c
@@ -284,6 +284,7 @@ tui_locator_window::set_locator_fullname (const char *fullname)
locator->full_name[0] = 0;
strcat_to_buf (locator->full_name, MAX_LOCATOR_ELEMENT_LEN, fullname);
+ rerender ();
}
/* See tui-stack.h. */
@@ -328,7 +329,6 @@ tui_update_locator_fullname (const char *fullname)
struct tui_locator_window *locator = tui_locator_win_info_ptr ();
locator->set_locator_fullname (fullname);
- tui_show_locator_content ();
}
/* Function to print the frame information for the TUI. The windows are
@@ -372,7 +372,6 @@ tui_show_frame_info (struct frame_info *fi)
if (!locator_changed_p)
return 0;
- tui_show_locator_content ();
for (struct tui_source_window_base *win_info : tui_source_windows ())
{
win_info->maybe_update (fi, sal, locator->line_no, locator->addr);
@@ -389,7 +388,6 @@ tui_show_frame_info (struct frame_info *fi)
if (!locator_changed_p)
return 0;
- tui_show_locator_content ();
for (struct tui_source_window_base *win_info : tui_source_windows ())
{
win_info->erase_source_content ();
--
2.17.2
next prev parent reply other threads:[~2019-08-21 2:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 2:27 [PATCH 00/15] More TUI Refactorings Tom Tromey
2019-08-21 2:25 ` [PATCH 04/15] Remove some calls in tui_data_window Tom Tromey
2019-08-21 2:25 ` Tom Tromey [this message]
2019-08-21 2:25 ` [PATCH 15/15] Remove tui_win_info::refresh_all Tom Tromey
2019-08-21 2:25 ` [PATCH 02/15] Remove tui_data_window::display_all_data Tom Tromey
2019-08-21 2:25 ` [PATCH 05/15] Private data members in tui_data_window Tom Tromey
2019-08-26 14:06 ` Pedro Alves
2019-08-30 19:06 ` Tom Tromey
2019-08-21 2:25 ` [PATCH 07/15] Remove NULL checks from box_win Tom Tromey
2019-08-21 2:25 ` [PATCH 01/15] Remove NO_DATA_STRING Tom Tromey
2019-08-21 2:25 ` [PATCH 06/15] Simplify register display Tom Tromey
2019-08-21 2:25 ` [PATCH 09/15] Don't call tui_refresh_all from show_layout Tom Tromey
2019-08-21 2:25 ` [PATCH 03/15] Remove some checks of .empty() Tom Tromey
2019-08-21 2:25 ` [PATCH 10/15] Turn two locator functions into methods Tom Tromey
2019-08-21 2:27 ` [PATCH 13/15] Minor rearrangement of tui-stack.c Tom Tromey
2019-08-21 2:27 ` [PATCH 08/15] Don't call touchwin in tui_gen_win_info::refresh_window Tom Tromey
2019-08-21 2:27 ` [PATCH 11/15] Swap tui_show_locator_content and tui_locator_window::rerender Tom Tromey
2019-08-21 2:31 ` [PATCH 14/15] Don't call wrefresh from tui_cont_sig Tom Tromey
2019-08-26 14:08 ` [PATCH 00/15] More TUI Refactorings Pedro Alves
2019-08-30 19:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821022535.9762-13-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).