From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 01/15] Remove NO_DATA_STRING
Date: Wed, 21 Aug 2019 02:25:00 -0000 [thread overview]
Message-ID: <20190821022535.9762-2-tom@tromey.com> (raw)
In-Reply-To: <20190821022535.9762-1-tom@tromey.com>
NO_DATA_STRING shouldn't be used. It's referenced in a single spot,
in tui_data_window::display_all_data. This patch removes the use and
replaces it with the more correct text. A later patch (though not in
this series) will remove this call entirely, when it's more obviously
correct to do so.
gdb/ChangeLog
2019-08-20 Tom Tromey <tom@tromey.com>
* tui/tui-regs.c (tui_data_window::display_all_data): Change
text.
* tui/tui-data.h (NO_DATA_STRING): Remove define.
---
gdb/ChangeLog | 6 ++++++
gdb/tui/tui-data.h | 1 -
gdb/tui/tui-regs.c | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 6dfea41d49e..698acac338f 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -97,7 +97,6 @@ public:
/* Constant definitions. */
#define DEFAULT_TAB_LEN 8
-#define NO_DATA_STRING "[ No Data Values Displayed ]"
#define SRC_NAME "src"
#define CMD_NAME "cmd"
#define DATA_NAME "regs"
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 71037d41047..24b182f2aec 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -437,7 +437,7 @@ void
tui_data_window::display_all_data ()
{
if (regs_content.empty ())
- erase_data_content (NO_DATA_STRING);
+ erase_data_content (_("[ Register Values Unavailable ]"));
else
{
erase_data_content (NULL);
--
2.17.2
next prev parent reply other threads:[~2019-08-21 2:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 2:27 [PATCH 00/15] More TUI Refactorings Tom Tromey
2019-08-21 2:25 ` [PATCH 02/15] Remove tui_data_window::display_all_data Tom Tromey
2019-08-21 2:25 ` [PATCH 15/15] Remove tui_win_info::refresh_all Tom Tromey
2019-08-21 2:25 ` [PATCH 04/15] Remove some calls in tui_data_window Tom Tromey
2019-08-21 2:25 ` [PATCH 12/15] Make tui_locator_window::set_locator_fullname re-render Tom Tromey
2019-08-21 2:25 ` [PATCH 10/15] Turn two locator functions into methods Tom Tromey
2019-08-21 2:25 ` [PATCH 09/15] Don't call tui_refresh_all from show_layout Tom Tromey
2019-08-21 2:25 ` [PATCH 03/15] Remove some checks of .empty() Tom Tromey
2019-08-21 2:25 ` [PATCH 06/15] Simplify register display Tom Tromey
2019-08-21 2:25 ` Tom Tromey [this message]
2019-08-21 2:25 ` [PATCH 07/15] Remove NULL checks from box_win Tom Tromey
2019-08-21 2:25 ` [PATCH 05/15] Private data members in tui_data_window Tom Tromey
2019-08-26 14:06 ` Pedro Alves
2019-08-30 19:06 ` Tom Tromey
2019-08-21 2:27 ` [PATCH 08/15] Don't call touchwin in tui_gen_win_info::refresh_window Tom Tromey
2019-08-21 2:27 ` [PATCH 13/15] Minor rearrangement of tui-stack.c Tom Tromey
2019-08-21 2:27 ` [PATCH 11/15] Swap tui_show_locator_content and tui_locator_window::rerender Tom Tromey
2019-08-21 2:31 ` [PATCH 14/15] Don't call wrefresh from tui_cont_sig Tom Tromey
2019-08-26 14:08 ` [PATCH 00/15] More TUI Refactorings Pedro Alves
2019-08-30 19:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821022535.9762-2-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).