From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] [PowerPC] Fix debug register issues in ppc-linux-nat
Date: Thu, 22 Aug 2019 10:27:00 -0000 [thread overview]
Message-ID: <20190822102716.5B677D8037D@oc3748833570.ibm.com> (raw)
In-Reply-To: <871rxefm5m.fsf@linux.ibm.com> from "Pedro Franco de Carvalho" at Aug 21, 2019 02:44:53 PM
Pedro Franco de Carvalho wrote:
> > The one question I still have is, given that we'll be deleting the
> > installed breakpoints after a clone/fork anyway, wouldn't it be
> > easier to just *delete* all breakpoints directly at the clone/fork
> > callback and start out the GDB "installed" structures as empty?
> > But that's just a minor detail ... whatever is easier to implement
> > is fine with me.
>
> I think it's easier to do it in prepare_to_resume, since we have to do
> it there anyway to handle hardware breakpoints that were removed by the
> user. I'm also not sure that linux-nat is prepared to take exceptions
> from these callbacks, in case a ptrace call there fails.
OK, makes sense.
> > Since this really seems to be required on PowerPC due to the peculiar
> > ptrace interface, I'm fine with adding the common code clone hook.
>
> Ok. Is it acceptable if linux-low in gdbserver doesn't have the
> equivalent hook? Adding one there would require changing struct
> linux_target_ops and every arch that uses it. This will become
> necessary in the future to enable hardware breakpoints in the ppc server
> stub.
Yes, I'd be fine with adding the hook to gdbserver as well then.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2019-08-22 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 12:50 [PATCH 0/3] low_new_clone in linux-nat.c and powerpc watchpoint fixes Pedro Franco de Carvalho
2019-07-26 12:50 ` [PATCH 2/3] [PowerPC] Move up some register access routines Pedro Franco de Carvalho
2019-08-08 16:25 ` Ulrich Weigand
2019-07-26 12:50 ` [PATCH 3/3] [PowerPC] Fix debug register issues in ppc-linux-nat Pedro Franco de Carvalho
2019-08-08 16:24 ` Ulrich Weigand
2019-08-08 20:27 ` Pedro Franco de Carvalho
2019-08-09 11:04 ` Ulrich Weigand
2019-08-09 15:04 ` Pedro Franco de Carvalho
2019-08-09 15:28 ` Ulrich Weigand
2019-08-09 15:53 ` Pedro Franco de Carvalho
2019-08-13 13:50 ` Pedro Franco de Carvalho
2019-08-21 15:31 ` Ulrich Weigand
2019-08-21 17:45 ` Pedro Franco de Carvalho
2019-08-22 10:27 ` Ulrich Weigand [this message]
2019-07-26 12:50 ` [PATCH 1/3] Add low_new_clone method to linux_nat_target Pedro Franco de Carvalho
2019-08-08 14:05 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822102716.5B677D8037D@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedromfc@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).