public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PING][8.3 backport] Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541)
Date: Mon, 09 Sep 2019 20:53:00 -0000	[thread overview]
Message-ID: <20190909205316.GA530@adacore.com> (raw)
In-Reply-To: <87r24wt3ki.fsf@redhat.com>

> >> OK to backport both commits to gdb-8.3-branch?
> >
> > Ping.
> 
> I'm the maintainer of the SystemTap/generic probe interfaces, but I'm
> not sure I can give you the green light for you in this case, because
> it's about backporting to a branch.  In any case, just to make sure I'm
> clear: this one LGTM.

Generally speaking, the rule is that a GM needs to approve the backport.
But the nod from the associated maintainer is always a great help.
So thanks a lot, Sergio!

I looked it over, and this seems safe to have. So the backport is
approved.

One thing that would have helped a bit is if the commits were attached
to the request. It's clearly not a big issue at all, but if they had
been attached, there would have been no mistake possible fo which
commits we are talking about, and looking through them would have been
faster.

For the record, I looked at:
  677052f2a5 Make stap-probe.c:stap_parse_register_operand's "regname" an std::string
  7d7571f0c1 Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541)

-- 
Joel

  reply	other threads:[~2019-09-09 20:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-14 17:52 Updates on GDB 8.3.1 and GDB 9 releases (2019-07-14) Joel Brobecker
2019-07-16 13:02 ` Tom de Vries
2019-08-12 21:44   ` Sergio Durigan Junior
2019-08-21  9:11     ` [8.3 backport] Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541) Tom de Vries
2019-09-04  8:19       ` [PING][8.3 " Tom de Vries
2019-09-04 16:43         ` Sergio Durigan Junior
2019-09-09 20:53           ` Joel Brobecker [this message]
2019-09-11 20:11             ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190909205316.GA530@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).