From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63383 invoked by alias); 19 Sep 2019 18:40:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63372 invoked by uid 89); 19 Sep 2019 18:40:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:754 X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Sep 2019 18:40:44 +0000 Received: by mail-wr1-f65.google.com with SMTP id v8so4209491wrt.2 for ; Thu, 19 Sep 2019 11:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iqpqlvY3y3OB/u9YFNfEvLLfmvymJv+1EVDIFiLa+Zg=; b=FM5l/MFGSqfwkTLWgBVcPH3tP0LhTykjur52Zafp5K5EP2hwYphM8j0ENV+73+ORIV 4fHi5b1Zc0NAZKfwRGctnCR2joih+VjrPTeUrujiYD/Y3Pfk9D4Uyk0DAKqZBwOm+wL+ oQ0PjdnCCuYM1GsoKYYz/ewhJAbnlw1BjFolowD9uwJGRoR09W5mDf1MrKhki5zVF0+o 0S2BSj6H3tWcL0BaZAa36MNHso/7NmRQGbNoP6Yq1YOrW4dHFqucgvFoXiAhc6s6BuP7 kve9u01UM1xkVtBNc7K6Fk61+w8ubajqg+VKhfIS9PYoWscR8qkxk23EA//a0PxXcNkm aE9A== Return-Path: Received: from localhost ([185.69.145.40]) by smtp.gmail.com with ESMTPSA id c132sm8923494wme.27.2019.09.19.11.40.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Sep 2019 11:40:41 -0700 (PDT) Date: Thu, 19 Sep 2019 18:40:00 -0000 From: Andrew Burgess To: Tom Tromey Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/8] Handle copy relocations Message-ID: <20190919184033.GE4962@embecosm.com> References: <20190801170412.5553-1-tromey@adacore.com> <20190801170412.5553-3-tromey@adacore.com> <20190821153528.GH6076@embecosm.com> <87ftlul4ed.fsf@tromey.com> <20190822084129.GK6076@embecosm.com> <87zhj0qiy1.fsf@tromey.com> <87tv98qgy9.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tv98qgy9.fsf@tromey.com> X-Fortune: Spelling is a lossed art. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00375.txt.bz2 * Tom Tromey [2019-09-19 12:27:58 -0600]: > >>>>> "Tom" == Tom Tromey writes: > > Andrew> I guess I'm thinking that we could merge the core of > Andrew> lookup_minimal_symbol_text and lookup_minimal_symbol_linkage (or > Andrew> _data), and just pass in a comparison function to check for either > Andrew> text or data symbols. > > Tom> Sounds good, I'll try that. There is already a separate debug iterator, > Tom> so maybe that can be used as well. > > I looked at this, but there isn't really that much to share. > > IMO callbacks tend to obfuscate the code. So I think I'd rather not do > that, if that's ok with you. That's fine it was only an idea. Thanks, Andrew