From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [committed][gdb/testsuite] Update expected _gdb_major/_gdb_minor in default.exp
Date: Wed, 09 Oct 2019 02:35:00 -0000 [thread overview]
Message-ID: <20191009023518.GB9616@adacore.com> (raw)
In-Reply-To: <87k19fez19.fsf@tromey.com>
> >> Is there some version-bumping script that must also be updated?
>
> Joel> You mean the nightly bump?
>
> No, I meant if you have a script to do the post-branch bump, does it
> need to be updated to fix up default.exp.
I wouldn't do it automatically. What I could be doing is add a reminder
to do it. But then, I'd have to test the change, as you never know
what I might be doing with those fat fingers of mine (and my evil
twin standing behind me begging to play with my keyboard and mouse).
I'm thinking instead we should change the test to be immune from
those version bumps.
Could we make that test verify that the minor number is zero, and
that the major number looks like a number, maybe?
Otherwise, how about extracting the version number from the output
of "show version" and then use that to validate the test(s)?
--
Joel
prev parent reply other threads:[~2019-10-09 2:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 15:35 [pushed/ob] Change gdb/version.in to 9.0.50.DATE-git (new version numbering scheme) Joel Brobecker
2019-10-07 10:54 ` [committed][gdb/testsuite] Update expected _gdb_major/_gdb_minor in default.exp Tom de Vries
2019-10-07 17:17 ` Tom Tromey
2019-10-08 1:53 ` Joel Brobecker
2019-10-08 20:57 ` Tom Tromey
2019-10-09 2:35 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009023518.GB9616@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).