From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4923 invoked by alias); 9 Oct 2019 02:35:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4693 invoked by uid 89); 9 Oct 2019 02:35:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=fat, evil, immune, reminder X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2019 02:35:21 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 33A055605B; Tue, 8 Oct 2019 22:35:20 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id fw0D9q5CL9Bj; Tue, 8 Oct 2019 22:35:20 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2987456059; Tue, 8 Oct 2019 22:35:19 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8ED0C82174; Tue, 8 Oct 2019 22:35:18 -0400 (EDT) Date: Wed, 09 Oct 2019 02:35:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [committed][gdb/testsuite] Update expected _gdb_major/_gdb_minor in default.exp Message-ID: <20191009023518.GB9616@adacore.com> References: <20191006153535.8332-1-brobecker@adacore.com> <87wodgiigo.fsf@tromey.com> <20191008015348.GB8857@adacore.com> <87k19fez19.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k19fez19.fsf@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-10/txt/msg00243.txt.bz2 > >> Is there some version-bumping script that must also be updated? > > Joel> You mean the nightly bump? > > No, I meant if you have a script to do the post-branch bump, does it > need to be updated to fix up default.exp. I wouldn't do it automatically. What I could be doing is add a reminder to do it. But then, I'd have to test the change, as you never know what I might be doing with those fat fingers of mine (and my evil twin standing behind me begging to play with my keyboard and mouse). I'm thinking instead we should change the test to be immune from those version bumps. Could we make that test verify that the minor number is zero, and that the major number looks like a number, maybe? Otherwise, how about extracting the version number from the output of "show version" and then use that to validate the test(s)? -- Joel