From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93753 invoked by alias); 14 Oct 2019 16:51:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93661 invoked by uid 89); 14 Oct 2019 16:51:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1573 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2019 16:51:04 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 542EE208F2; Mon, 14 Oct 2019 12:51:02 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 17A3720806; Mon, 14 Oct 2019 12:51:00 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id E668929ECF; Mon, 14 Oct 2019 12:50:59 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Mon, 14 Oct 2019 16:51:00 -0000 From: "Tom de Vries (Code Review)" To: gdb-patches@sourceware.org Cc: Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: Change in binutils-gdb[master]: [gdb/symtab] Prefer var def over decl X-Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 X-Gerrit-Change-Number: 29 X-Gerrit-ChangeURL: X-Gerrit-Commit: f885ed071fe8d3124112e010fc0446374eb5aaf1 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 14 Oct 2019 12:50:59 -0400 Reply-To: tdevries@suse.de, sergiodj@sergiodj.net, andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191014165059.E668929ECF@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00372.txt.bz2 Tom de Vries has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29 ) Change subject: [gdb/symtab] Prefer var def over decl ...................................................................... Patch Set 2: (2 comments) Added missing function comments. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/1/gdb/block.c File gdb/block.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/1/gdb/block.c@729 PS1, Line 729: best_symbol (struct symbol *a, const domain_enum domain) > All functions should have a header comment: https://sourceware. […] Done https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/1/gdb/block.c@736 PS1, Line 736: better_symbol (struct symbol *a, struct symbol *b, const domain_enum domain) > Again, needs a comment. Done -- To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29 To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 Gerrit-Change-Number: 29 Gerrit-PatchSet: 2 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Tom de Vries Gerrit-Comment-Date: Mon, 14 Oct 2019 16:50:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Andrew Burgess Gerrit-MessageType: comment