From: "Tom de Vries (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Luis Machado <luis.machado@linaro.org>,
Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [review] [gdb/symtab] Prefer var def over decl
Date: Fri, 18 Oct 2019 16:44:00 -0000 [thread overview]
Message-ID: <20191018164451.E761220AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571043046000.Id92326cb8ef9903b121ef9e320658eb565d0f5a9@gnutoolchain-gerrit.osci.io>
Tom de Vries has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29
......................................................................
Patch Set 2:
> Patch Set 2: Code-Review+1
>
> (2 comments)
>
> I've noticed a couple nits.
>
> If PR91507 is fixed, do we need to patch GDB up?
Yes. We need both the fix of PR91507 and this GDB patch to fix the test-case.
> Or do we want to adapt GDB to the broken output from older GCC as well?
As mentioned in the rationale, that is possible by getting the size from minimal symbol info, but I consider that a workaround rather than a fix. I've filed that as a separate PR: https://sourceware.org/bugzilla/show_bug.cgi?id=24989 .
> I'm inclined to at least add some comment to the code stating GCC's broken behavior and why we're fixing it in this particular way.
>
Ack, will add.
> Otherwise this looks good to me.
next prev parent reply other threads:[~2019-10-18 16:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1571043046000.Id92326cb8ef9903b121ef9e320658eb565d0f5a9@gnutoolchain-gerrit.osci.io>
2019-10-14 16:35 ` Change in binutils-gdb[master]: " Tom de Vries (Code Review)
2019-10-14 16:51 ` Tom de Vries (Code Review)
2019-10-18 13:31 ` [review] " Luis Machado (Code Review)
2019-10-18 16:44 ` Tom de Vries (Code Review) [this message]
2019-10-23 16:27 ` [review v3] " Tom de Vries (Code Review)
2019-10-23 16:29 ` Tom de Vries (Code Review)
2019-10-31 15:50 ` Tom Tromey (Code Review)
2019-11-04 1:11 ` Joel Brobecker (Code Review)
2019-11-07 14:27 ` Tom de Vries (Code Review)
2019-11-07 15:30 ` Tom de Vries (Code Review)
2019-11-11 16:45 ` Joel Brobecker (Code Review)
2019-11-14 16:38 ` Tom de Vries (Code Review)
2019-11-21 13:34 ` Tom Tromey (Code Review)
2019-11-22 10:24 ` Tom de Vries (Code Review)
2019-11-22 11:02 ` Tom de Vries (Code Review)
2019-11-22 12:17 ` [review v4] " Tom de Vries (Code Review)
2019-11-22 12:19 ` Tom de Vries (Code Review)
2019-12-05 20:29 ` Tom Tromey (Code Review)
2019-12-06 17:53 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-06 17:53 ` Sourceware to Gerrit sync (Code Review)
2019-12-09 6:29 ` [review v5] " Tom de Vries (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018164451.E761220AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).