From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: [review] gdb/testsuite: Merge cvexpr.exp and ctf-cvexpr.exp
Date: Fri, 18 Oct 2019 18:19:00 -0000 [thread overview]
Message-ID: <20191018181911.F154620AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571177353000.If678c3e38cb444867defa970203d26563f15dba4@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/122
......................................................................
Patch Set 1: Code-Review+2
This looks reasonable to me. Thank you for doing this.
I guess this test isn't very expensive to run, so looping like this is fine.
next prev parent reply other threads:[~2019-10-18 18:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 22:09 Andrew Burgess (Code Review)
2019-10-18 18:19 ` Tom Tromey (Code Review) [this message]
2019-11-18 17:54 ` [review v2] " Andrew Burgess (Code Review)
2019-11-18 17:57 ` [review v3] " Andrew Burgess (Code Review)
2019-11-18 18:47 ` Simon Marchi (Code Review)
2019-11-19 0:47 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-19 0:47 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018181911.F154620AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).