From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review] Style diassembly in the TUI
Date: Tue, 22 Oct 2019 01:25:00 -0000 [thread overview]
Message-ID: <20191022012503.B48202192E@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571678978000.I8722635eeecbbb1633d943a65b856404c2d467b0@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/179
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+1
>
> (1 comment)
>
> I am completely clueless about how the TUI works, but I tried it briefly locally and it works as advertised.
>
> I noticed a small bug, where when I turn the styling on and off, it seems to affect the character count on some lines and shifts the content left and right. It's easier shown with a video:
>
> https://nova.polymtl.ca/~simark/Peek%202019-10-21%2018-11.webm
>
> I wouldn't consider this a blocker, but I thought it would be good to mention it.
Good catch, thanks. I think the problem is that the styling escapes are counted
as characters.
The only straightforward way I see to fix this is to call `print_address` twice --
once with styling, and once without. A more complicated way would be to strip the
escapes from the string before computing the length.
WDTY?
next prev parent reply other threads:[~2019-10-22 1:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 17:29 Tom Tromey (Code Review)
2019-10-21 22:16 ` Simon Marchi (Code Review)
2019-10-22 1:25 ` Tom Tromey (Code Review) [this message]
2019-10-22 4:27 ` Simon Marchi (Code Review)
2019-10-30 21:13 ` Matt Rice
2019-10-30 23:11 ` Tom Tromey
2019-10-23 14:00 ` [review v2] " Tom Tromey (Code Review)
2019-10-23 14:22 ` Tom Tromey (Code Review)
2019-10-30 19:30 ` Simon Marchi (Code Review)
2019-10-30 22:56 ` [review v3] Style disassembly " Tom Tromey (Code Review)
2019-11-05 22:23 ` Tom Tromey (Code Review)
2019-11-05 22:36 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-05 22:36 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022012503.B48202192E@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).