From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75946 invoked by alias); 30 Oct 2019 15:22:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75930 invoked by uid 89); 30 Oct 2019 15:22:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Oct 2019 15:22:52 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id ACAF120322; Wed, 30 Oct 2019 11:22:50 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 69E0820322; Wed, 30 Oct 2019 11:22:49 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 2AF6420AF6; Wed, 30 Oct 2019 11:22:49 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Wed, 30 Oct 2019 15:22:00 -0000 From: "Luis Machado (Code Review)" To: gdb-patches@sourceware.org Cc: Tom Tromey , Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] [ARM, Thumb] Fix disassembling bug after reloading a symbol file X-Gerrit-Change-Id: I22c3e6ebe9bfedad66d56fe9656994fa1761c485 X-Gerrit-Change-Number: 447 X-Gerrit-ChangeURL: X-Gerrit-Commit: 00b908c1cc399a6bb4f8fce55edac19be11b3385 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 30 Oct 2019 11:22:49 -0400 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-74-g460fb0f7e9 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191030152249.2AF6420AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg01098.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447 ...................................................................... Patch Set 2: (2 comments) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/2//COMMIT_MSG Commit Message: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/2//COMMIT_MSG@62 PS2, Line 62: 53 | (arm_bfd_data_key): ... this. 54 | (arm_find_mapping_symbol): Adjust access to new bfd_key-based 55 | data. 56 | (arm_record_special_symbol): Likewise. 57 | 58 | gdb/testsuite/ChangeLog: 59 | 60 | 2019-01-29 Luis Machado 61 | 62 | * gdb.arch/pr25124.S: New file. > If there's a PR open for this, then each ChangeLog should […] Great. I'll add it. Thanks for the catching that. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/2/gdb/arm-tdep.c File gdb/arm-tdep.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/447/2/gdb/arm-tdep.c@117 PS2, Line 117: 108 | symbol value (address). */ 109 | std::unique_ptr section_maps; 110 | 111 | /* For each corresponding element of section_maps above, is this vector 112 | sorted. */ 113 | std::unique_ptr section_maps_sorted; 114 | }; 115 | 116 | /* Per-bfd data used for mapping symbols. */ 117 | static bfd_key arm_bfd_data_key; > I wonder if `arm_exidx_data_key` needs this treatment as well? I did go through it when doing the change. It seems a bit more complicated, and it is attached to an observer, but i think it makes sense to convert it too. I'll make a separate patch for it, since, unlike this particular case, the exidx processing doesn't suffer from not getting updated when we reload the objfile. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I22c3e6ebe9bfedad66d56fe9656994fa1761c485 Gerrit-Change-Number: 447 Gerrit-PatchSet: 2 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Luis Machado Gerrit-CC: Andrew Burgess Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Wed, 30 Oct 2019 15:22:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tom Tromey Gerrit-MessageType: comment