From: "Luis Machado (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Subject: [review] Share windows_thread_info between gdb and gdbserver
Date: Thu, 31 Oct 2019 04:01:00 -0000 [thread overview]
Message-ID: <20191031040128.80BC920AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572371871000.I9ba2d1b94be1550ea2e75e977d0808c7a27e2223@gnutoolchain-gerrit.osci.io>
Luis Machado has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407
......................................................................
Patch Set 1:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407/1/gdb/nat/windows-nat.h
File gdb/nat/windows-nat.h:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/407/1/gdb/nat/windows-nat.h@35
PS1, Line 35:
24 | struct windows_thread_info
| ...
30 | HANDLE h;
31 |
32 | /* Thread Information Block address. */
33 | CORE_ADDR thread_local_base;
34 |
35 > /* Non zero if SuspendThread was called on this thread. */
36 | int suspended;
37 |
38 | #ifdef _WIN32_WCE
39 | /* The context as retrieved right after suspending the thread. */
40 | CONTEXT base_context;
> This discrepancy between Non zero here and Nonzero below caught my attention. […]
Nevermind. I noticed a later patch replaces this comment.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9ba2d1b94be1550ea2e75e977d0808c7a27e2223
Gerrit-Change-Number: 407
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Comment-Date: Thu, 31 Oct 2019 04:01:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Luis Machado <luis.machado@linaro.org>
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-10-31 4:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 17:58 Tom Tromey (Code Review)
2019-10-31 3:54 ` Luis Machado (Code Review)
2019-10-31 4:01 ` Luis Machado (Code Review) [this message]
2019-10-31 18:13 ` Simon Marchi (Code Review)
2019-11-26 17:11 ` [review v2] " Tom Tromey (Code Review)
2019-11-29 17:54 ` Pedro Alves (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031040128.80BC920AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).