From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Cc: Luis Machado <luis.machado@linaro.org>
Subject: [review] Remove the "next" field from windows_thread_info
Date: Thu, 31 Oct 2019 14:20:00 -0000 [thread overview]
Message-ID: <20191031142047.34FB620AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572371871000.Ib93c54e529a5d82515883f44a478eeb0ff0dbae9@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/404
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/404/1//COMMIT_MSG
Commit Message:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/404/1//COMMIT_MSG@11
PS1, Line 11:
6 |
7 | Remove the "next" field from windows_thread_info
8 |
9 | This changes windows_thread_info to remove the "next" field, replacing
10 | the linked list of threads with a vector. This is a prerequisite to
11 > sharing is structure with gdbserver, which manages threads
12 | differently.
13 |
14 | gdb/ChangeLog
15 | 2019-10-29 Tom Tromey <tromey@adacore.com>
16 |
"this"?
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ib93c54e529a5d82515883f44a478eeb0ff0dbae9
Gerrit-Change-Number: 404
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Thu, 31 Oct 2019 14:20:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-10-31 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 17:57 Tom Tromey (Code Review)
2019-10-31 3:18 ` Luis Machado (Code Review)
2019-10-31 14:20 ` Simon Marchi (Code Review) [this message]
2019-11-12 19:42 ` Tom Tromey (Code Review)
2019-11-12 19:58 ` Tom Tromey (Code Review)
2019-11-26 17:11 ` [review v2] " Tom Tromey (Code Review)
2019-11-29 17:47 ` Pedro Alves (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031142047.34FB620AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=luis.machado@linaro.org \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).