From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>,
Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [review v3] gdb: recognize new DWARF attributes: defaulted, deleted, calling conv.
Date: Thu, 31 Oct 2019 20:18:00 -0000 [thread overview]
Message-ID: <20191031201838.A0BE720AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571406803000.I54192f363115b78ec7435a8563b73fcace420765@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135
......................................................................
Patch Set 3:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/3/gdb/dwarf2read.c
File gdb/dwarf2read.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/3/gdb/dwarf2read.c@15452
PS3, Line 15452:
15444 | is_valid_DW_AT_defaulted (ULONGEST value)
| ...
15447 | {
15448 | case DW_DEFAULTED_no:
15449 | case DW_DEFAULTED_in_class:
15450 | case DW_DEFAULTED_out_of_class:
15451 | return true;
15452 > }
15453 |
15454 | complaint (_("unrecognized DW_AT_defaulted value (%lu)"), value);
15455 | return false;
15456 | }
15457 |
> I did not put a "default" case here whereas in 'is_valid_DW_AT_calling_convention_for_type' there is […]
I think this is fine, thanks.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I54192f363115b78ec7435a8563b73fcace420765
Gerrit-Change-Number: 135
Gerrit-PatchSet: 3
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 31 Oct 2019 20:18:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-10-31 20:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 13:53 [review] " Tankut Baris Aktemur (Code Review)
2019-10-18 14:02 ` Tankut Baris Aktemur (Code Review)
2019-10-23 14:31 ` Tom Tromey (Code Review)
2019-10-29 22:20 ` Tom Tromey (Code Review)
2019-10-30 3:30 ` Simon Marchi (Code Review)
2019-10-31 9:43 ` Tankut Baris Aktemur (Code Review)
2019-10-31 14:10 ` Simon Marchi (Code Review)
2019-10-31 17:22 ` Tankut Baris Aktemur (Code Review)
2019-10-31 17:24 ` [review v2] " Tankut Baris Aktemur (Code Review)
2019-10-31 17:57 ` Simon Marchi (Code Review)
2019-10-31 20:07 ` [review v3] " Tankut Baris Aktemur (Code Review)
2019-10-31 20:12 ` Simon Marchi (Code Review)
2019-10-31 20:12 ` Simon Marchi (Code Review)
2019-10-31 20:13 ` Tankut Baris Aktemur (Code Review)
2019-10-31 20:18 ` Simon Marchi (Code Review) [this message]
2019-12-20 16:47 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-20 16:47 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031201838.A0BE720AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tankut.baris.aktemur@intel.com \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).