[review v2] gdb: Introduce symbol_search_spec

["Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264
......................................................................


Patch Set 2:

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264/1/gdb/symtab.c 
File gdb/symtab.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264/1/gdb/symtab.c@4449 
PS1, Line 4449: 
4444 | }
4445 | 
4446 | /* See symtab.h.  */
4447 | 
4448 | std::vector<symbol_search>
4449 > search_symbols (const search_symbols_spec &search_spec)
4450 > {
4451 >   /* Unpack the search spec.  */
4452 >   const char *regexp = search_spec.symbol_regexp;
4453 >   enum search_domain kind = search_spec.kind;
4454 >   const char *t_regexp = search_spec.type_regexp;
4455 >   int nfiles = search_spec.filenames.size ();
4456 >   bool exclude_minsyms = search_spec.exclude_minsyms;
4457 | 
4458 |   /* The search.  */
4459 |   const struct blockvector *bv;
4460 |   const struct block *b;
4461 |   int i = 0;

> Did you consider making search_symbols a method of […]

I've done this in the new version of this patch.  This had more of an impact for later patches in the series.



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I488ab292a892d9e9e84775c632c5f198b6ad3710
Gerrit-Change-Number: 264
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 01:30:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: comment