* [review] Move check for strerror_r to common.m4 where it belongs
@ 2019-10-31 23:25 Christian Biesinger (Code Review)
2019-11-01 12:26 ` Tom Tromey (Code Review)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christian Biesinger (Code Review) @ 2019-10-31 23:25 UTC (permalink / raw)
To: gdb-patches; +Cc: Christian Biesinger
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/480
......................................................................
Move check for strerror_r to common.m4 where it belongs
gdb/ChangeLog:
2019-10-31 Christian Biesinger <cbiesinger@google.com>
* configure: Regenerate.
* configure.ac: Remove check for strerror_r.
* gdbsupport/common.m4: Check for strerror_r.
gdb/gdbserver/ChangeLog:
2019-10-31 Christian Biesinger <cbiesinger@google.com>
* configure: Regenerate.
* configure.ac: Remove check for strerror_r.
Change-Id: Ibc290c3f84b1db23e998cffdbe2c1f97651d2a8d
---
M gdb/configure
M gdb/configure.ac
M gdb/gdbserver/configure
M gdb/gdbserver/configure.ac
M gdb/gdbsupport/common.m4
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/gdb/configure b/gdb/configure
index 018cc4b..512f016 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -13073,7 +13073,7 @@
sigaction sigsetmask socketpair \
ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
setrlimit getrlimit posix_madvise waitpid \
- ptrace64 sigaltstack setns use_default_colors strerror_r
+ ptrace64 sigaltstack setns use_default_colors
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
@@ -13480,7 +13480,7 @@
for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
- sigprocmask
+ sigprocmask strerror_r
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 987507a..354bb7b 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1318,7 +1318,7 @@
sigaction sigsetmask socketpair \
ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
setrlimit getrlimit posix_madvise waitpid \
- ptrace64 sigaltstack setns use_default_colors strerror_r])
+ ptrace64 sigaltstack setns use_default_colors])
AM_LANGINFO_CODESET
GDB_AC_COMMON
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 7bf9fa2..3f1f1c1 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -6448,7 +6448,7 @@
fi
-for ac_func in getauxval pread pwrite pread64 setns strerror_r
+for ac_func in getauxval pread pwrite pread64 setns
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
@@ -6822,7 +6822,7 @@
for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
- sigprocmask
+ sigprocmask strerror_r
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac
index 44fee8b..7ebc9c3 100644
--- a/gdb/gdbserver/configure.ac
+++ b/gdb/gdbserver/configure.ac
@@ -90,7 +90,7 @@
sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl
netinet/tcp.h arpa/inet.h)
AC_FUNC_FORK
-AC_CHECK_FUNCS(getauxval pread pwrite pread64 setns strerror_r)
+AC_CHECK_FUNCS(getauxval pread pwrite pread64 setns)
GDB_AC_COMMON
diff --git a/gdb/gdbsupport/common.m4 b/gdb/gdbsupport/common.m4
index 471d705..2e44cf4 100644
--- a/gdb/gdbsupport/common.m4
+++ b/gdb/gdbsupport/common.m4
@@ -33,7 +33,7 @@
dlfcn.h)
AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction \
- sigprocmask])
+ sigprocmask strerror_r])
AC_CHECK_DECLS([strerror, strstr])
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibc290c3f84b1db23e998cffdbe2c1f97651d2a8d
Gerrit-Change-Number: 480
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 4+ messages in thread
* [review] Move check for strerror_r to common.m4 where it belongs
2019-10-31 23:25 [review] Move check for strerror_r to common.m4 where it belongs Christian Biesinger (Code Review)
@ 2019-11-01 12:26 ` Tom Tromey (Code Review)
2019-11-01 15:15 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-01 15:15 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey (Code Review) @ 2019-11-01 12:26 UTC (permalink / raw)
To: Christian Biesinger, gdb-patches
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/480
......................................................................
Patch Set 1: Code-Review+2
Thanks for doing this. This is ok.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibc290c3f84b1db23e998cffdbe2c1f97651d2a8d
Gerrit-Change-Number: 480
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 12:26:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pushed] Move check for strerror_r to common.m4 where it belongs
2019-10-31 23:25 [review] Move check for strerror_r to common.m4 where it belongs Christian Biesinger (Code Review)
2019-11-01 12:26 ` Tom Tromey (Code Review)
2019-11-01 15:15 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-11-01 15:15 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-01 15:15 UTC (permalink / raw)
To: Christian Biesinger, gdb-patches; +Cc: Tom Tromey
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/480
......................................................................
Move check for strerror_r to common.m4 where it belongs
gdb/ChangeLog:
2019-11-01 Christian Biesinger <cbiesinger@google.com>
* configure: Regenerate.
* configure.ac: Remove check for strerror_r.
* gdbsupport/common.m4: Check for strerror_r.
gdb/gdbserver/ChangeLog:
2019-11-01 Christian Biesinger <cbiesinger@google.com>
* configure: Regenerate.
* configure.ac: Remove check for strerror_r.
Change-Id: Ibc290c3f84b1db23e998cffdbe2c1f97651d2a8d
---
M gdb/ChangeLog
M gdb/configure
M gdb/configure.ac
M gdb/gdbserver/ChangeLog
M gdb/gdbserver/configure
M gdb/gdbserver/configure.ac
M gdb/gdbsupport/common.m4
7 files changed, 18 insertions(+), 7 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e2bdd5f..4231ac1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2019-11-01 Christian Biesinger <cbiesinger@google.com>
+
+ * configure: Regenerate.
+ * configure.ac: Remove check for strerror_r.
+ * gdbsupport/common.m4: Check for strerror_r.
+
2019-11-01 Luis Machado <luis.machado@linaro.org>
PR gdb/25124
diff --git a/gdb/configure b/gdb/configure
index 018cc4b..512f016 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -13073,7 +13073,7 @@
sigaction sigsetmask socketpair \
ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
setrlimit getrlimit posix_madvise waitpid \
- ptrace64 sigaltstack setns use_default_colors strerror_r
+ ptrace64 sigaltstack setns use_default_colors
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
@@ -13480,7 +13480,7 @@
for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
- sigprocmask
+ sigprocmask strerror_r
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 987507a..354bb7b 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1318,7 +1318,7 @@
sigaction sigsetmask socketpair \
ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
setrlimit getrlimit posix_madvise waitpid \
- ptrace64 sigaltstack setns use_default_colors strerror_r])
+ ptrace64 sigaltstack setns use_default_colors])
AM_LANGINFO_CODESET
GDB_AC_COMMON
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index ab03f88..35684db 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-01 Christian Biesinger <cbiesinger@google.com>
+
+ * configure: Regenerate.
+ * configure.ac: Remove check for strerror_r.
+
2019-10-31 Christian Biesinger <cbiesinger@google.com>
* config.in: Regenerate.
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 7bf9fa2..3f1f1c1 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -6448,7 +6448,7 @@
fi
-for ac_func in getauxval pread pwrite pread64 setns strerror_r
+for ac_func in getauxval pread pwrite pread64 setns
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
@@ -6822,7 +6822,7 @@
for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
- sigprocmask
+ sigprocmask strerror_r
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac
index 44fee8b..7ebc9c3 100644
--- a/gdb/gdbserver/configure.ac
+++ b/gdb/gdbserver/configure.ac
@@ -90,7 +90,7 @@
sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl
netinet/tcp.h arpa/inet.h)
AC_FUNC_FORK
-AC_CHECK_FUNCS(getauxval pread pwrite pread64 setns strerror_r)
+AC_CHECK_FUNCS(getauxval pread pwrite pread64 setns)
GDB_AC_COMMON
diff --git a/gdb/gdbsupport/common.m4 b/gdb/gdbsupport/common.m4
index 471d705..2e44cf4 100644
--- a/gdb/gdbsupport/common.m4
+++ b/gdb/gdbsupport/common.m4
@@ -33,7 +33,7 @@
dlfcn.h)
AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction \
- sigprocmask])
+ sigprocmask strerror_r])
AC_CHECK_DECLS([strerror, strstr])
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibc290c3f84b1db23e998cffdbe2c1f97651d2a8d
Gerrit-Change-Number: 480
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pushed] Move check for strerror_r to common.m4 where it belongs
2019-10-31 23:25 [review] Move check for strerror_r to common.m4 where it belongs Christian Biesinger (Code Review)
2019-11-01 12:26 ` Tom Tromey (Code Review)
@ 2019-11-01 15:15 ` Sourceware to Gerrit sync (Code Review)
2019-11-01 15:15 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-01 15:15 UTC (permalink / raw)
To: Christian Biesinger, Tom Tromey, gdb-patches
The original change was created by Christian Biesinger.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/480
......................................................................
Move check for strerror_r to common.m4 where it belongs
gdb/ChangeLog:
2019-11-01 Christian Biesinger <cbiesinger@google.com>
* configure: Regenerate.
* configure.ac: Remove check for strerror_r.
* gdbsupport/common.m4: Check for strerror_r.
gdb/gdbserver/ChangeLog:
2019-11-01 Christian Biesinger <cbiesinger@google.com>
* configure: Regenerate.
* configure.ac: Remove check for strerror_r.
Change-Id: Ibc290c3f84b1db23e998cffdbe2c1f97651d2a8d
---
M gdb/ChangeLog
M gdb/configure
M gdb/configure.ac
M gdb/gdbserver/ChangeLog
M gdb/gdbserver/configure
M gdb/gdbserver/configure.ac
M gdb/gdbsupport/common.m4
7 files changed, 18 insertions(+), 7 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e2bdd5f..4231ac1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2019-11-01 Christian Biesinger <cbiesinger@google.com>
+
+ * configure: Regenerate.
+ * configure.ac: Remove check for strerror_r.
+ * gdbsupport/common.m4: Check for strerror_r.
+
2019-11-01 Luis Machado <luis.machado@linaro.org>
PR gdb/25124
diff --git a/gdb/configure b/gdb/configure
index 018cc4b..512f016 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -13073,7 +13073,7 @@
sigaction sigsetmask socketpair \
ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
setrlimit getrlimit posix_madvise waitpid \
- ptrace64 sigaltstack setns use_default_colors strerror_r
+ ptrace64 sigaltstack setns use_default_colors
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
@@ -13480,7 +13480,7 @@
for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
- sigprocmask
+ sigprocmask strerror_r
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 987507a..354bb7b 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1318,7 +1318,7 @@
sigaction sigsetmask socketpair \
ttrace wborder wresize setlocale iconvlist libiconvlist btowc \
setrlimit getrlimit posix_madvise waitpid \
- ptrace64 sigaltstack setns use_default_colors strerror_r])
+ ptrace64 sigaltstack setns use_default_colors])
AM_LANGINFO_CODESET
GDB_AC_COMMON
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index ab03f88..35684db 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-01 Christian Biesinger <cbiesinger@google.com>
+
+ * configure: Regenerate.
+ * configure.ac: Remove check for strerror_r.
+
2019-10-31 Christian Biesinger <cbiesinger@google.com>
* config.in: Regenerate.
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 7bf9fa2..3f1f1c1 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -6448,7 +6448,7 @@
fi
-for ac_func in getauxval pread pwrite pread64 setns strerror_r
+for ac_func in getauxval pread pwrite pread64 setns
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
@@ -6822,7 +6822,7 @@
for ac_func in fdwalk getrlimit pipe pipe2 socketpair sigaction \
- sigprocmask
+ sigprocmask strerror_r
do :
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac
index 44fee8b..7ebc9c3 100644
--- a/gdb/gdbserver/configure.ac
+++ b/gdb/gdbserver/configure.ac
@@ -90,7 +90,7 @@
sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl
netinet/tcp.h arpa/inet.h)
AC_FUNC_FORK
-AC_CHECK_FUNCS(getauxval pread pwrite pread64 setns strerror_r)
+AC_CHECK_FUNCS(getauxval pread pwrite pread64 setns)
GDB_AC_COMMON
diff --git a/gdb/gdbsupport/common.m4 b/gdb/gdbsupport/common.m4
index 471d705..2e44cf4 100644
--- a/gdb/gdbsupport/common.m4
+++ b/gdb/gdbsupport/common.m4
@@ -33,7 +33,7 @@
dlfcn.h)
AC_CHECK_FUNCS([fdwalk getrlimit pipe pipe2 socketpair sigaction \
- sigprocmask])
+ sigprocmask strerror_r])
AC_CHECK_DECLS([strerror, strstr])
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibc290c3f84b1db23e998cffdbe2c1f97651d2a8d
Gerrit-Change-Number: 480
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-01 15:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 23:25 [review] Move check for strerror_r to common.m4 where it belongs Christian Biesinger (Code Review)
2019-11-01 12:26 ` Tom Tromey (Code Review)
2019-11-01 15:15 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-01 15:15 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).