From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124900 invoked by alias); 4 Nov 2019 04:31:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124886 invoked by uid 89); 4 Nov 2019 04:31:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=H*M:lan, concerned, over-long, overlong X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Nov 2019 04:31:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572841886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XJJBhuIATMk6DqX0lgQHshgg/u59NVFiPW/04QaPpU0=; b=Be7stE+qKyAkQga3aCtNgxYg4MFQcaPKqMp2sBIzL1fB24Ik1bXfnxvXwhyBO1Ok8z9g0y zDXF/jMIQPpn5qDbhHV1SQh99iRLZfOMc+sCY7CzdbkEoFeV0kFgZbrcgAcEfBVK0pXm7x +i9j7NjX+j+I+ekm5hlG+7dSsa8EaFY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-9-GhMSCLxjOLutMZSrFUiBFA-1; Sun, 03 Nov 2019 23:31:21 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 61F69107ACC2; Mon, 4 Nov 2019 04:31:20 +0000 (UTC) Received: from f29-4.lan (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3732E5C1D8; Mon, 4 Nov 2019 04:31:20 +0000 (UTC) Date: Mon, 04 Nov 2019 04:31:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH 2/2] OpenMP parallel region scope tests Message-ID: <20191103213119.1687945c@f29-4.lan> In-Reply-To: <87r23xah4f.fsf@tromey.com> References: <20190822171408.28271-1-kevinb@redhat.com> <20190822171408.28271-3-kevinb@redhat.com> <87r23xah4f.fsf@tromey.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00075.txt.bz2 On Mon, 30 Sep 2019 10:22:40 -0600 Tom Tromey wrote: > >>>>> "Kevin" =3D=3D Kevin Buettner writes:=20=20 >=20 > Kevin> Add tests which check for accessibility of variables from within > Kevin> various OpenMP parallel regions.=20=20 >=20 > I don't know anything about OpenMP, so I didn't read new .c file. > I'm not especially concerned about it though. >=20 > Kevin> +if {[gdb_compile_openmp "${srcdir}/${subdir}/${srcfile}" "${binfi= le}" executable {debug}] !=3D ""} {=20=20 >=20 > Over-long line. >=20 > Kevin> +if {[info procs openmp_setup] !=3D ""} { > Kevin> + if {[openmp_setup $binfile] !=3D ""} { > Kevin> + return -1=20=20 >=20 > Does this need a call to "untested"? >=20 > The rest seemed fine to me. Thanks for the review. I've addressed both of your concerns in my most recent patch submitted via gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/504 Kevin