From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84503 invoked by alias); 4 Nov 2019 17:16:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84493 invoked by uid 89); 4 Nov 2019 17:16:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Nov 2019 17:16:26 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 826E120250; Mon, 4 Nov 2019 12:16:24 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id DF7C32039A; Mon, 4 Nov 2019 12:16:22 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id BAB2825B28; Mon, 4 Nov 2019 12:16:22 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Mon, 04 Nov 2019 17:16:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Christian Biesinger Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Introduce program_space::add_objfile X-Gerrit-Change-Id: I93e8525dda631cb89dcc2046a5c51c7c9f34ccfd X-Gerrit-Change-Number: 495 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1fa5a523b7c35af98d206461a1b59da304bf6bd0 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 4 Nov 2019 12:16:22 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191104171622.BAB2825B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00095.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/495 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/495/1/gdb/objfiles.c File gdb/objfiles.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/495/1/gdb/objfiles.c@512 PS1, Line 512: 502 | objfile::make (bfd *bfd_, const char *name_, objfile_flags flags_, | ... 507 | add_separate_debug_objfile (result, parent); 508 | 509 | current_program_space->add_objfile (result, parent); 510 | 511 | /* Rebuild section map next time we need it. */ 512 > get_objfile_pspace_data (current_program_space)->new_objfiles_available = 1; 513 | 514 | return result; 515 | } 516 | 517 | /* See objfiles.h. */ > Maybe this should be done by add_objfile instead? The objfile module stores some state on the program space, so I think it's probably something that should be kept here. At least, for the time being; maybe this should just be a field on the program space instead of a side object; I am not sure. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I93e8525dda631cb89dcc2046a5c51c7c9f34ccfd Gerrit-Change-Number: 495 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Tom Tromey Gerrit-CC: Christian Biesinger Gerrit-Comment-Date: Mon, 04 Nov 2019 17:16:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christian Biesinger Gerrit-MessageType: comment