* [review] Change tui_source_element::line to have type std::string
@ 2019-10-21 17:29 Tom Tromey (Code Review)
2019-10-21 17:37 ` Simon Marchi (Code Review)
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-21 17:29 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/178
......................................................................
Change tui_source_element::line to have type std::string
This changes tui_source_element::line to be of type std::string. This
reduces the number of copies made.
gdb/ChangeLog
2019-10-21 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_element) <line>: Now a
std::string.
* tui/tui-winsource.c (tui_show_source_line): Update.
* tui/tui-source.c (tui_source_window::set_contents): Update.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
Change-Id: Id600f3e1d386a2911f187366e05e2ec599068dd2
---
M gdb/ChangeLog
M gdb/tui/tui-disasm.c
M gdb/tui/tui-source.c
M gdb/tui/tui-winsource.c
M gdb/tui/tui-winsource.h
5 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 44980f2..b0268e3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,13 @@
2019-10-21 Tom Tromey <tom@tromey.com>
+ * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
+ std::string.
+ * tui/tui-winsource.c (tui_show_source_line): Update.
+ * tui/tui-source.c (tui_source_window::set_contents): Update.
+ * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
+
+2019-10-21 Tom Tromey <tom@tromey.com>
+
* tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2019-10-21 Tom Tromey <tom@tromey.com>
diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index 33a3ba1..91c9845 100644
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -216,10 +216,10 @@
+ asm_lines[i].insn);
/* Now copy the line taking the offset into account. */
- if (line.size() > offset)
- src->line.reset (xstrndup (&line[offset], line_width));
+ if (line.size () > offset)
+ src->line = line.substr (offset, line_width);
else
- src->line = make_unique_xstrdup ("");
+ src->line.clear ();
src->line_or_addr.loa = LOA_ADDRESS;
src->line_or_addr.u.addr = asm_lines[i].addr;
diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index bb1013b..f956645 100644
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -183,7 +183,7 @@
symtab_to_fullname (s)) == 0
&& cur_line_no == locator->line_no);
- content[cur_line].line = make_unique_xstrdup (text.c_str ());
+ content[cur_line].line = std::move (text);
cur_line++;
cur_line_no++;
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 3fbc49f..5d0bcb4 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -222,7 +222,7 @@
tui_set_reverse_mode (win_info->handle.get (), true);
wmove (win_info->handle.get (), lineno, TUI_EXECINFO_SIZE);
- tui_puts (line->line.get (), win_info->handle.get ());
+ tui_puts (line->line.c_str (), win_info->handle.get ());
if (line->is_exec_point)
tui_set_reverse_mode (win_info->handle.get (), false);
diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index 9417b28..185d3dd 100644
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -62,7 +62,7 @@
{
}
- gdb::unique_xmalloc_ptr<char> line;
+ std::string line;
struct tui_line_or_address line_or_addr;
bool is_exec_point = false;
tui_bp_flags break_mode = 0;
^ permalink raw reply [flat|nested] 7+ messages in thread
* [review] Change tui_source_element::line to have type std::string
2019-10-21 17:29 [review] Change tui_source_element::line to have type std::string Tom Tromey (Code Review)
@ 2019-10-21 17:37 ` Simon Marchi (Code Review)
2019-10-23 14:00 ` [review v2] " Tom Tromey (Code Review)
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-21 17:37 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/178
......................................................................
Patch Set 1: Code-Review+2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [review v2] Change tui_source_element::line to have type std::string
2019-10-21 17:29 [review] Change tui_source_element::line to have type std::string Tom Tromey (Code Review)
2019-10-21 17:37 ` Simon Marchi (Code Review)
@ 2019-10-23 14:00 ` Tom Tromey (Code Review)
2019-10-30 19:23 ` Simon Marchi (Code Review)
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-23 14:00 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/178
......................................................................
Change tui_source_element::line to have type std::string
This changes tui_source_element::line to be of type std::string. This
reduces the number of copies made.
gdb/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_element) <line>: Now a
std::string.
* tui/tui-winsource.c (tui_show_source_line): Update.
* tui/tui-source.c (tui_source_window::set_contents): Update.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
Change-Id: Id600f3e1d386a2911f187366e05e2ec599068dd2
---
M gdb/ChangeLog
M gdb/tui/tui-disasm.c
M gdb/tui/tui-source.c
M gdb/tui/tui-winsource.c
M gdb/tui/tui-winsource.h
5 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 253c74f..edc9171 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2019-10-23 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
+ std::string.
+ * tui/tui-winsource.c (tui_show_source_line): Update.
+ * tui/tui-source.c (tui_source_window::set_contents): Update.
+ * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
+
2019-10-23 Tom de Vries <tdevries@suse.de>
PR breakpoints/24687
diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index 33a3ba1..91c9845 100644
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -216,10 +216,10 @@
+ asm_lines[i].insn);
/* Now copy the line taking the offset into account. */
- if (line.size() > offset)
- src->line.reset (xstrndup (&line[offset], line_width));
+ if (line.size () > offset)
+ src->line = line.substr (offset, line_width);
else
- src->line = make_unique_xstrdup ("");
+ src->line.clear ();
src->line_or_addr.loa = LOA_ADDRESS;
src->line_or_addr.u.addr = asm_lines[i].addr;
diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index bb1013b..f956645 100644
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -183,7 +183,7 @@
symtab_to_fullname (s)) == 0
&& cur_line_no == locator->line_no);
- content[cur_line].line = make_unique_xstrdup (text.c_str ());
+ content[cur_line].line = std::move (text);
cur_line++;
cur_line_no++;
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 3fbc49f..5d0bcb4 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -222,7 +222,7 @@
tui_set_reverse_mode (win_info->handle.get (), true);
wmove (win_info->handle.get (), lineno, TUI_EXECINFO_SIZE);
- tui_puts (line->line.get (), win_info->handle.get ());
+ tui_puts (line->line.c_str (), win_info->handle.get ());
if (line->is_exec_point)
tui_set_reverse_mode (win_info->handle.get (), false);
diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index 9417b28..185d3dd 100644
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -62,7 +62,7 @@
{
}
- gdb::unique_xmalloc_ptr<char> line;
+ std::string line;
struct tui_line_or_address line_or_addr;
bool is_exec_point = false;
tui_bp_flags break_mode = 0;
^ permalink raw reply [flat|nested] 7+ messages in thread
* [review v2] Change tui_source_element::line to have type std::string
2019-10-21 17:29 [review] Change tui_source_element::line to have type std::string Tom Tromey (Code Review)
2019-10-21 17:37 ` Simon Marchi (Code Review)
2019-10-23 14:00 ` [review v2] " Tom Tromey (Code Review)
@ 2019-10-30 19:23 ` Simon Marchi (Code Review)
2019-10-30 22:56 ` [review v3] " Tom Tromey (Code Review)
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-30 19:23 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/178
......................................................................
Patch Set 2: Code-Review+2
I think this patch could be pushed on its own, it's a good cleanup.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id600f3e1d386a2911f187366e05e2ec599068dd2
Gerrit-Change-Number: 178
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 30 Oct 2019 19:23:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 7+ messages in thread
* [review v3] Change tui_source_element::line to have type std::string
2019-10-21 17:29 [review] Change tui_source_element::line to have type std::string Tom Tromey (Code Review)
` (2 preceding siblings ...)
2019-10-30 19:23 ` Simon Marchi (Code Review)
@ 2019-10-30 22:56 ` Tom Tromey (Code Review)
2019-11-05 22:36 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-05 22:36 ` Sourceware to Gerrit sync (Code Review)
5 siblings, 0 replies; 7+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-30 22:56 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/178
......................................................................
Change tui_source_element::line to have type std::string
This changes tui_source_element::line to be of type std::string. This
reduces the number of copies made.
gdb/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_element) <line>: Now a
std::string.
* tui/tui-winsource.c (tui_show_source_line): Update.
* tui/tui-source.c (tui_source_window::set_contents): Update.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
Change-Id: Id600f3e1d386a2911f187366e05e2ec599068dd2
---
M gdb/ChangeLog
M gdb/tui/tui-disasm.c
M gdb/tui/tui-source.c
M gdb/tui/tui-winsource.c
M gdb/tui/tui-winsource.h
5 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0382082..5f93b2b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2019-10-23 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
+ std::string.
+ * tui/tui-winsource.c (tui_show_source_line): Update.
+ * tui/tui-source.c (tui_source_window::set_contents): Update.
+ * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
+
2019-10-30 Christian Biesinger <cbiesinger@google.com>
* minsyms.c (clear_minimal_symbol_hash_tables): New function.
diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index 33a3ba1..91c9845 100644
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -216,10 +216,10 @@
+ asm_lines[i].insn);
/* Now copy the line taking the offset into account. */
- if (line.size() > offset)
- src->line.reset (xstrndup (&line[offset], line_width));
+ if (line.size () > offset)
+ src->line = line.substr (offset, line_width);
else
- src->line = make_unique_xstrdup ("");
+ src->line.clear ();
src->line_or_addr.loa = LOA_ADDRESS;
src->line_or_addr.u.addr = asm_lines[i].addr;
diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index bb1013b..f956645 100644
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -183,7 +183,7 @@
symtab_to_fullname (s)) == 0
&& cur_line_no == locator->line_no);
- content[cur_line].line = make_unique_xstrdup (text.c_str ());
+ content[cur_line].line = std::move (text);
cur_line++;
cur_line_no++;
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 3fbc49f..5d0bcb4 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -222,7 +222,7 @@
tui_set_reverse_mode (win_info->handle.get (), true);
wmove (win_info->handle.get (), lineno, TUI_EXECINFO_SIZE);
- tui_puts (line->line.get (), win_info->handle.get ());
+ tui_puts (line->line.c_str (), win_info->handle.get ());
if (line->is_exec_point)
tui_set_reverse_mode (win_info->handle.get (), false);
diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index 9417b28..185d3dd 100644
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -62,7 +62,7 @@
{
}
- gdb::unique_xmalloc_ptr<char> line;
+ std::string line;
struct tui_line_or_address line_or_addr;
bool is_exec_point = false;
tui_bp_flags break_mode = 0;
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id600f3e1d386a2911f187366e05e2ec599068dd2
Gerrit-Change-Number: 178
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 7+ messages in thread
* [pushed] Change tui_source_element::line to have type std::string
2019-10-21 17:29 [review] Change tui_source_element::line to have type std::string Tom Tromey (Code Review)
` (3 preceding siblings ...)
2019-10-30 22:56 ` [review v3] " Tom Tromey (Code Review)
@ 2019-11-05 22:36 ` Sourceware to Gerrit sync (Code Review)
2019-11-05 22:36 ` Sourceware to Gerrit sync (Code Review)
5 siblings, 0 replies; 7+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-05 22:36 UTC (permalink / raw)
To: Tom Tromey, Simon Marchi, gdb-patches
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/178
......................................................................
Change tui_source_element::line to have type std::string
This changes tui_source_element::line to be of type std::string. This
reduces the number of copies made.
gdb/ChangeLog
2019-11-05 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_element) <line>: Now a
std::string.
* tui/tui-winsource.c (tui_show_source_line): Update.
* tui/tui-source.c (tui_source_window::set_contents): Update.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
Change-Id: Id600f3e1d386a2911f187366e05e2ec599068dd2
---
M gdb/ChangeLog
M gdb/tui/tui-disasm.c
M gdb/tui/tui-source.c
M gdb/tui/tui-winsource.c
M gdb/tui/tui-winsource.h
5 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index efa66ee..0c05afe 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2019-11-05 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
+ std::string.
+ * tui/tui-winsource.c (tui_show_source_line): Update.
+ * tui/tui-source.c (tui_source_window::set_contents): Update.
+ * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
+
2019-11-05 Christian Biesinger <cbiesinger@google.com>
* symtab.h (gdb_static_assert): Put && operator at the beginning
diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index 33a3ba1..91c9845 100644
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -216,10 +216,10 @@
+ asm_lines[i].insn);
/* Now copy the line taking the offset into account. */
- if (line.size() > offset)
- src->line.reset (xstrndup (&line[offset], line_width));
+ if (line.size () > offset)
+ src->line = line.substr (offset, line_width);
else
- src->line = make_unique_xstrdup ("");
+ src->line.clear ();
src->line_or_addr.loa = LOA_ADDRESS;
src->line_or_addr.u.addr = asm_lines[i].addr;
diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index bb1013b..f956645 100644
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -183,7 +183,7 @@
symtab_to_fullname (s)) == 0
&& cur_line_no == locator->line_no);
- content[cur_line].line = make_unique_xstrdup (text.c_str ());
+ content[cur_line].line = std::move (text);
cur_line++;
cur_line_no++;
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 3fbc49f..5d0bcb4 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -222,7 +222,7 @@
tui_set_reverse_mode (win_info->handle.get (), true);
wmove (win_info->handle.get (), lineno, TUI_EXECINFO_SIZE);
- tui_puts (line->line.get (), win_info->handle.get ());
+ tui_puts (line->line.c_str (), win_info->handle.get ());
if (line->is_exec_point)
tui_set_reverse_mode (win_info->handle.get (), false);
diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index 9417b28..185d3dd 100644
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -62,7 +62,7 @@
{
}
- gdb::unique_xmalloc_ptr<char> line;
+ std::string line;
struct tui_line_or_address line_or_addr;
bool is_exec_point = false;
tui_bp_flags break_mode = 0;
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id600f3e1d386a2911f187366e05e2ec599068dd2
Gerrit-Change-Number: 178
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 7+ messages in thread
* [pushed] Change tui_source_element::line to have type std::string
2019-10-21 17:29 [review] Change tui_source_element::line to have type std::string Tom Tromey (Code Review)
` (4 preceding siblings ...)
2019-11-05 22:36 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-11-05 22:36 ` Sourceware to Gerrit sync (Code Review)
5 siblings, 0 replies; 7+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-05 22:36 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Simon Marchi
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/178
......................................................................
Change tui_source_element::line to have type std::string
This changes tui_source_element::line to be of type std::string. This
reduces the number of copies made.
gdb/ChangeLog
2019-11-05 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_element) <line>: Now a
std::string.
* tui/tui-winsource.c (tui_show_source_line): Update.
* tui/tui-source.c (tui_source_window::set_contents): Update.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
Change-Id: Id600f3e1d386a2911f187366e05e2ec599068dd2
---
M gdb/ChangeLog
M gdb/tui/tui-disasm.c
M gdb/tui/tui-source.c
M gdb/tui/tui-winsource.c
M gdb/tui/tui-winsource.h
5 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index efa66ee..0c05afe 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2019-11-05 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
+ std::string.
+ * tui/tui-winsource.c (tui_show_source_line): Update.
+ * tui/tui-source.c (tui_source_window::set_contents): Update.
+ * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
+
2019-11-05 Christian Biesinger <cbiesinger@google.com>
* symtab.h (gdb_static_assert): Put && operator at the beginning
diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index 33a3ba1..91c9845 100644
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -216,10 +216,10 @@
+ asm_lines[i].insn);
/* Now copy the line taking the offset into account. */
- if (line.size() > offset)
- src->line.reset (xstrndup (&line[offset], line_width));
+ if (line.size () > offset)
+ src->line = line.substr (offset, line_width);
else
- src->line = make_unique_xstrdup ("");
+ src->line.clear ();
src->line_or_addr.loa = LOA_ADDRESS;
src->line_or_addr.u.addr = asm_lines[i].addr;
diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index bb1013b..f956645 100644
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -183,7 +183,7 @@
symtab_to_fullname (s)) == 0
&& cur_line_no == locator->line_no);
- content[cur_line].line = make_unique_xstrdup (text.c_str ());
+ content[cur_line].line = std::move (text);
cur_line++;
cur_line_no++;
diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 3fbc49f..5d0bcb4 100644
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -222,7 +222,7 @@
tui_set_reverse_mode (win_info->handle.get (), true);
wmove (win_info->handle.get (), lineno, TUI_EXECINFO_SIZE);
- tui_puts (line->line.get (), win_info->handle.get ());
+ tui_puts (line->line.c_str (), win_info->handle.get ());
if (line->is_exec_point)
tui_set_reverse_mode (win_info->handle.get (), false);
diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index 9417b28..185d3dd 100644
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -62,7 +62,7 @@
{
}
- gdb::unique_xmalloc_ptr<char> line;
+ std::string line;
struct tui_line_or_address line_or_addr;
bool is_exec_point = false;
tui_bp_flags break_mode = 0;
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id600f3e1d386a2911f187366e05e2ec599068dd2
Gerrit-Change-Number: 178
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-11-05 22:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 17:29 [review] Change tui_source_element::line to have type std::string Tom Tromey (Code Review)
2019-10-21 17:37 ` Simon Marchi (Code Review)
2019-10-23 14:00 ` [review v2] " Tom Tromey (Code Review)
2019-10-30 19:23 ` Simon Marchi (Code Review)
2019-10-30 22:56 ` [review v3] " Tom Tromey (Code Review)
2019-11-05 22:36 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-05 22:36 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).