From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58844 invoked by alias); 8 Nov 2019 00:28:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58835 invoked by uid 89); 8 Nov 2019 00:28:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=Unless X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2019 00:28:28 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 11D3320250; Thu, 7 Nov 2019 19:28:27 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 1DAEF20387; Thu, 7 Nov 2019 19:28:22 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id DF71C25B28; Thu, 7 Nov 2019 19:28:21 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Fri, 08 Nov 2019 00:28:00 -0000 From: "Christian Biesinger (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Cc: Christian Biesinger Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb: Don't reorder line table entries too much when sorting. X-Gerrit-Change-Id: Ia0309494be4cfd9dcc554f30209477f5f040b21b X-Gerrit-Change-Number: 526 X-Gerrit-ChangeURL: X-Gerrit-Commit: 26b5131ebd13bb4bb7bc8fb452c207d3967e9900 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 7 Nov 2019 19:28:21 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191108002821.DF71C25B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00218.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/526 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/526/1/gdb/buildsym.c File gdb/buildsym.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/526/1/gdb/buildsym.c@957 PS1, Line 957: 902 | buildsym_compunit::end_symtab_with_blockvector (struct block *static_block, | ... 952 | return true; 953 | 954 | if (ln1.pc > ln2.pc) 955 | return false; 956 | 957 > /* For line table entries at the same address we don't want 958 | to reorder them. */ 959 | ptrdiff_t off1 = &ln1 - &subfile->line_vector->item[0]; 960 | ptrdiff_t off2 = &ln2 - &subfile->line_vector->item[0]; 961 | return off1 < off2; 962 | }; Perhaps use std::stable_sort instead of doing it this way? (Unless I misunderstood the purpose of this) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ia0309494be4cfd9dcc554f30209477f5f040b21b Gerrit-Change-Number: 526 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Burgess Gerrit-CC: Christian Biesinger Gerrit-Comment-Date: Fri, 08 Nov 2019 00:28:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment