From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6633 invoked by alias); 8 Nov 2019 11:14:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6620 invoked by uid 89); 8 Nov 2019 11:14:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=luck X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2019 11:14:27 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id AC0ED20AF8; Fri, 8 Nov 2019 06:14:23 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 9E7D220387; Fri, 8 Nov 2019 06:14:22 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 7BD9625B28; Fri, 8 Nov 2019 06:14:22 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Fri, 08 Nov 2019 11:14:00 -0000 From: "Andrew Burgess (Code Review)" To: gdb-patches@sourceware.org Cc: Christian Biesinger Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb: Don't reorder line table entries too much when sorting. X-Gerrit-Change-Id: Ia0309494be4cfd9dcc554f30209477f5f040b21b X-Gerrit-Change-Number: 526 X-Gerrit-ChangeURL: X-Gerrit-Commit: 26b5131ebd13bb4bb7bc8fb452c207d3967e9900 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 8 Nov 2019 06:14:22 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Content-Type: text/plain; charset=UTF-8 Message-Id: <20191108111422.7BD9625B28@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00225.txt.bz2 Andrew Burgess has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/526 ...................................................................... Patch Set 1: Yes, after thinking about this patch over night I realised what I wrote was just wrong, it only works by total luck, I suspect because mostly there's not much actual sorting being done. I still think the aim of the patch is correct, but I need a better method, I'll investigate std::stable_sort as a possibility. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ia0309494be4cfd9dcc554f30209477f5f040b21b Gerrit-Change-Number: 526 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-CC: Christian Biesinger Gerrit-Comment-Date: Fri, 08 Nov 2019 11:14:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment