From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47827 invoked by alias); 9 Nov 2019 00:05:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47820 invoked by uid 89); 9 Nov 2019 00:05:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Nov 2019 00:05:58 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 6DA0820AF8; Fri, 8 Nov 2019 19:05:56 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id B9E9620362; Fri, 8 Nov 2019 19:05:54 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 524F12816F; Fri, 8 Nov 2019 19:05:54 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Sat, 09 Nov 2019 00:05:00 -0000 From: "Simon Marchi (Code Review)" To: Sergio Durigan Junior , gdb-patches@sourceware.org Cc: Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] Fix crash with core + TUI + run X-Gerrit-Change-Id: I39e2f8b538c580c8ea5bf1d657ee877e47746c8f X-Gerrit-Change-Number: 483 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2ba4b368991cf0ca1f8e7189986aefe6c03cea81 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 8 Nov 2019 19:05:53 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191109000554.524F12816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00248.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/483 ...................................................................... Patch Set 2: (1 comment) | --- gdb/target.c | +++ gdb/target.c | @@ -569,14 +566,18 @@ target_stack::push (target_ops *t) | - } | + prev = m_stack[stratum]; | | /* Now add the new one. */ | m_stack[stratum] = t; | | + /* And close the previous one, if it exists. */ | + if (prev != nullptr) | + target_close (prev); | + PS1, Line 574: > > Now with a quote. > > Quote^2. Testing again. | if (m_top < stratum) | m_top = stratum; | } | | /* See target.h. */ | | void | push_target (struct target_ops *t) | { -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I39e2f8b538c580c8ea5bf1d657ee877e47746c8f Gerrit-Change-Number: 483 Gerrit-PatchSet: 2 Gerrit-Owner: Sergio Durigan Junior Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Sergio Durigan Junior Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Sat, 09 Nov 2019 00:05:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Comment-In-Reply-To: Sergio Durigan Junior Gerrit-MessageType: comment