[review] Allow using less horizontal space in TUI source window

["Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/605
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/tui/tui-source.c
| +++ gdb/tui/tui-source.c
| @@ -76,12 +80,19 @@ tui_source_window::set_contents (struct gdbarch *arch,
|  	  cur_line = 0;
|  	  gdbarch = get_objfile_arch (SYMTAB_OBJFILE (s));
|  	  start_line_or_addr.loa = LOA_LINE;
|  	  cur_line_no = start_line_or_addr.u.line_no = line_no;
|  
| +	  int digits = 0;
| +	  if (compact_source)
| +	    {
| +	      double l = log10 (offsets->size ()) + 1;
| +	      digits = 1 + (int) l;

PS1, Line 89:

If I understand correctly one of the +1's here is for the white space
that is displayed on the left of the number when it is being printed
(the calculation here always gives number of digits + 1).  However it
feels a little weird to me to have part of the display logic here, and
part of the display logic in tui_copy_source_line.

Personally I'd rather have this calculation always return the correct
number of digits and have all display logic - what whitespace is where
inside tui_copy_source_line.

| +	    }
| +
|  	  const char *iter = srclines.c_str ();
|  	  content.resize (nlines);
|  	  while (cur_line < nlines)
|  	    {
|  	      struct tui_source_element *element
|  		= &content[cur_line];
|  

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I46ce9a68b12c9c79332d510f9c14b3c84b7efadd
Gerrit-Change-Number: 605
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Mon, 11 Nov 2019 11:19:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment