From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115733 invoked by alias); 11 Nov 2019 16:45:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115632 invoked by uid 89); 11 Nov 2019 16:45:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=controlled, sk:luisma, luis, Luis X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Nov 2019 16:45:25 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 430472046F; Mon, 11 Nov 2019 11:45:19 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id E77DD201E8; Mon, 11 Nov 2019 11:45:16 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id C08CE20AF6; Mon, 11 Nov 2019 11:45:16 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Mon, 11 Nov 2019 16:45:00 -0000 From: "Joel Brobecker (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Cc: Tom Tromey , Luis Machado , Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] [gdb/symtab] Prefer var def over decl X-Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 X-Gerrit-Change-Number: 29 X-Gerrit-ChangeURL: X-Gerrit-Commit: cede0513116b126cb1ef7506cd1ff25eb86cf878 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 11 Nov 2019 11:45:16 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191111164516.C08CE20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00290.txt.bz2 Joel Brobecker has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29 ...................................................................... Patch Set 3: > > > The patch itself seems perfectly fine to me. I appreciated the comment > > > and the test case -- those help a lot. > > > > > > However, I wonder why gdb is even making a symbol for a declaration in the > > > first place. For some other kinds of declarations, gdb doesn't bother, so > > > I was wondering if it's possible to simply ignore them in general. > > > > Another way to ask the same question is what would it mean to have a type which has a declaration, but no definition. Wouldn't we still want to know about that type? > > The thing with types is that we can list them using info types, which makes them visible. > > Variable declarations by themselves are not visible, only variable definitions. But the declaration can help to add information that's not available at the definition, as I've tried to explain in more detail at the previous comment. At this stage of the discussion, I think it shows that the subject is a little bit delicate and maybe we should start viewing the resolution for the 9.x branch separately from the resolution in master, because 9.x should be imminent. For me, the current patch is OK for 9.x, as it seems its impact is relatively controlled. The ignore.patch fix, on the other hand, seems a little too risky for inclusion this late before we branch 9.x. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 Gerrit-Change-Number: 29 Gerrit-PatchSet: 3 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Tom de Vries Gerrit-CC: Joel Brobecker Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Mon, 11 Nov 2019 16:45:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment